Skip to content

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jul 17, 2024

Since dotnet/roslyn#66535, IDE0060: Remove unused parameter doesn't warn for throw-only methods.

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 17, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 17, 2024
@xtqqczze xtqqczze changed the title Fix unnecessary IDE0060 suppressions Remove unnecessary IDE0060 suppressions Jul 17, 2024
@xtqqczze xtqqczze force-pushed the IDE060-AlwaysThrow branch from 0c793b5 to aea31bc Compare July 17, 2024 23:36
Since dotnet/roslyn#66535 `IDE0060` doesn't warn for throw-only methods.
@xtqqczze xtqqczze force-pushed the IDE060-AlwaysThrow branch from aea31bc to 29829ba Compare July 17, 2024 23:38
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is green. Thanks.

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@xtqqczze
Copy link
Contributor Author

@stephentoub Sorry, I force-pushed after your approval; I've reset back to 29829ba.

@stephentoub stephentoub merged commit db32911 into dotnet:main Jul 22, 2024
@xtqqczze xtqqczze deleted the IDE060-AlwaysThrow branch July 22, 2024 12:35
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants