Skip to content

Generate forwarder if all parameters can't be marshaled in LibraryImport #104246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+14 −1
Closed

Generate forwarder if all parameters can't be marshaled in LibraryImport #104246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion ...aries/System.Runtime.InteropServices/gen/LibraryImportGenerator/LibraryImportGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,19 @@ private static (MemberDeclarationSyntax, ImmutableArray<DiagnosticInfo>) Generat
return (PrintForwarderStub(pinvokeStub.StubMethodSyntaxTemplate, explicitForwarding: true, pinvokeStub, diagnostics), pinvokeStub.Diagnostics.Array.AddRange(diagnostics.Diagnostics));
}

bool supportsTargetFramework = !pinvokeStub.LibraryImportData.SetLastError
|| options.GenerateForwarders
|| (pinvokeStub.TargetFramework is (TargetFramework.Net, { Major: >= 6 }));

foreach (TypePositionInfo typeInfo in pinvokeStub.SignatureContext.ElementTypeInformation)
{
if (typeInfo.MarshallingAttributeInfo is MissingSupportMarshallingInfo)
{
supportsTargetFramework = false;
break;
}
}

// Generate stub code
var stubGenerator = new PInvokeStubCodeGenerator(
pinvokeStub.GeneratorFactoryKey.Key.TargetFramework,
Expand All @@ -325,7 +338,7 @@ private static (MemberDeclarationSyntax, ImmutableArray<DiagnosticInfo>) Generat
// Check if the generator should produce a forwarder stub - regular DllImport.
// This is done if the signature is blittable or the target framework is not supported.
if (stubGenerator.StubIsBasicForwarder
|| !stubGenerator.SupportsTargetFramework)
|| !supportsTargetFramework)
{
return (PrintForwarderStub(pinvokeStub.StubMethodSyntaxTemplate, !stubGenerator.SupportsTargetFramework, pinvokeStub, diagnostics), pinvokeStub.Diagnostics.Array.AddRange(diagnostics.Diagnostics));
}
Expand Down