Skip to content

JIT: Add a disabled-by-default implementation of strength reduction #104243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 4, 2024
Merged

JIT: Add a disabled-by-default implementation of strength reduction #104243

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1786472
JIT: Add a disabled-by-default implementation of strength reduction
jakobbotsch Jun 28, 2024
efb641c
Fix a GC hole
jakobbotsch Jul 1, 2024
3a1850a
Disallow GC typed add recs
jakobbotsch Jul 2, 2024
7c0e2f8
Merge branch 'main' of github.com:dotnet/runtime into strength-reduct…
jakobbotsch Jul 2, 2024
3d66247
Disable strength reduction
jakobbotsch Jul 2, 2024
c06728d
Fix some comments
jakobbotsch Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/coreclr/jit/arraystack.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,11 @@ class ArrayStack
tosIndex = 0;
}

T* Data()
{
return data;
}

private:
CompAllocator m_alloc;
int tosIndex; // first free location
Expand Down
6 changes: 4 additions & 2 deletions src/coreclr/jit/compiler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6430,11 +6430,9 @@ class Compiler
Statement* fgNewStmtAtEnd(BasicBlock* block, GenTree* tree, const DebugInfo& di = DebugInfo());
Statement* fgNewStmtNearEnd(BasicBlock* block, GenTree* tree, const DebugInfo& di = DebugInfo());

private:
void fgInsertStmtNearEnd(BasicBlock* block, Statement* stmt);
void fgInsertStmtAtBeg(BasicBlock* block, Statement* stmt);

public:
void fgInsertStmtAfter(BasicBlock* block, Statement* insertionPoint, Statement* stmt);
void fgInsertStmtBefore(BasicBlock* block, Statement* insertionPoint, Statement* stmt);

Expand Down Expand Up @@ -7562,6 +7560,8 @@ class Compiler

PhaseStatus optInductionVariables();

template <typename TFunctor>
void optVisitBoundingExitingCondBlocks(FlowGraphNaturalLoop* loop, TFunctor func);
bool optMakeLoopDownwardsCounted(ScalarEvolutionContext& scevContext,
FlowGraphNaturalLoop* loop,
LoopLocalOccurrences* loopLocals);
Expand Down Expand Up @@ -10344,6 +10344,8 @@ class Compiler
STRESS_MODE(OPT_REPEAT) /* stress JitOptRepeat */ \
STRESS_MODE(INITIAL_PARAM_REG) /* Stress initial register assigned to parameters */ \
STRESS_MODE(DOWNWARDS_COUNTED_LOOPS) /* Make more loops downwards counted */ \
STRESS_MODE(STRENGTH_REDUCTION) /* Enable strength reduction */ \
STRESS_MODE(STRENGTH_REDUCTION_PROFITABILITY) /* Do more strength reduction */ \
\
/* After COUNT_VARN, stress level 2 does all of these all the time */ \
\
Expand Down
Loading