Skip to content

[RISC-V] Classify stack arguments as single segment #103619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2024
Merged

[RISC-V] Classify stack arguments as single segment #103619

merged 1 commit into from
Jun 18, 2024

Conversation

@tomeksowi
Copy link
Member

@tomeksowi tomeksowi commented Jun 18, 2024

#103537 (comment) jakobbotsch#4 (comment)

Part of #84834, cc @dotnet/samsung

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 18, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 18, 2024
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Jun 18, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@clamp03 clamp03 added the arch-riscv Related to the RISC-V architecture label Jun 18, 2024
@risc-vv
Copy link

risc-vv commented Jun 18, 2024

RISC-V test results for qemu-prio1-checked (Checked build): 9401 / 9405 (99.96%)

details

GIT: 8ca3903
Build mode: Checked
Links:

  1. tests_results.xml
  2. tests_output.tar.gz /pipelines//qemu-prio1-checked/12/run-tests/1/ALL/testoutput/test_datails.Checked.tar.gz
  3. coreclr/prio1 tests binary /pipelines//build-runtime-checked/33/build-tests-prio1/1/build/coreclr.Checked.prio1.tar.gz
  4. clr+libs+host binary /pipelines//build-runtime-checked/33/build-core/1/build/artifacts.Checked.tar.gz
  5. testhost binary /pipelines//build-runtime-checked/33/build-core/1/build/testhost.Checked.tar.gz

=======================
      passed: 9401
      failed: 3
     skipped: 42
      killed: 1
------------------------
  TOTAL libs: 9447
 TOTAL tests: 9447
   REAL time: 1h 18min 16s 188ms
=======================
failed tests 
[50.470s] profiler.unittest.releaseondetach.releaseondetach
    releaseondetach.sh
    [exitcode-134]: SIGABRT Abort. Managed or native assert, or runtime check such as heap corruption, caused call to abort(). Core dumped.
[42.660s] JIT.Directed.debugging.debuginfo.tester.tester
    tester.sh
    [exitcode-  -1]: unknown error
[733.890s] readytorun.coreroot_determinism.coreroot_determinism.coreroot_determinism
    coreroot_determinism.sh
    [exitcode-  1]: unknown error
killed tests 
[1811.965s] profiler.eventpipe.reverse_startup.reverse_startup
    reverse_startup.sh
skipped tests 
[0.000s] Interop.MonoAPI.MonoMono.InstallEHCallback.InstallEHCallback
    InstallEHCallback.sh
[0.000s] Interop.MonoAPI.MonoMono.PInvokeDetach.PInvokeDetach
    PInvokeDetach.sh
[0.000s] Interop.MonoAPI.MonoMono.Thunks.Thunks
    Thunks.sh
[0.000s] tracing.eventpipe.eventsourceerror.eventsourceerror.eventsourceerror
    eventsourceerror.sh
[0.000s] JIT.Directed.arglist.vararg_TargetUnix.vararg_TargetUnix
    vararg_TargetUnix.sh
[0.000s] JIT.Directed.rvastatics.RVAOrderingTest.RVAOrderingTest
    RVAOrderingTest.sh
[0.000s] JIT.Directed.PREFIX.volatile.1.arglist_Target_64BIT_volatile.arglist_Target_64BIT_volatile
    arglist_Target_64BIT_volatile.sh
[0.000s] JIT.Directed.PREFIX.unaligned.4.arglist_Target_64BIT_unaligned_4.arglist_Target_64BIT_unaligned_4
    arglist_Target_64BIT_unaligned_4.sh
[0.000s] JIT.Directed.PREFIX.unaligned.1.arglist_Target_64BIT_unaligned_1.arglist_Target_64BIT_unaligned_1
    arglist_Target_64BIT_unaligned_1.sh
[0.000s] JIT.Directed.PREFIX.unaligned.2.arglist_Target_64BIT_unaligned_2.arglist_Target_64BIT_unaligned_2
    arglist_Target_64BIT_unaligned_2.sh
[0.000s] JIT.opt.ValueNumbering.ExposedLocalsNumbering.ExposedLocalsNumbering
    ExposedLocalsNumbering.sh
[0.000s] JIT.opt.SSA.MemorySsa.MemorySsa
    MemorySsa.sh
[0.000s] JIT.Methodical.refany.seq_d.seq_d
    seq_d.sh
[0.000s] JIT.Methodical.refany.seq_r.seq_r
    seq_r.sh
[0.000s] JIT.Methodical.Coverage.arglist_pos.arglist_pos
    arglist_pos.sh
[0.000s] JIT.Regression.CLR-x86-JIT.V1-M12-Beta2.b37646.b37646.b37646
    b37646.sh
[0.000s] JIT.Regression.CLR-x86-JIT.V1-M12-Beta2.b41852.b41852.b41852
    b41852.sh
[0.000s] JIT.Regression.CLR-x86-JIT.V1-M12-Beta2.b31746.b31746.b31746
    b31746.sh
[0.000s] JIT.Regression.CLR-x86-JIT.V1-M11-Beta1.b41391.b41391.b41391
    b41391.sh
[0.000s] JIT.Regression.CLR-x86-JIT.V1-M09.5-PDC.b16423.b16423.b16423
    b16423.sh
[0.000s] JIT.Regression.JitBlue.Runtime_57606.Runtime_57606.Runtime_57606
    Runtime_57606.sh
[0.000s] JIT.Regression.CLR-x86-EJIT.V1-M12-Beta2.b26323.b26323.b26323
    b26323.sh
[0.000s] JIT.jit64.mcc.interop.mcc_i00.mcc_i00
    mcc_i00.sh
[0.000s] Loader.binding.tracing.BinderTracingTest.Basic.BinderTracingTest.Basic
    BinderTracingTest.Basic.sh
[0.000s] readytorun.GenericCycleDetection.Depth3Test.Depth3Test
    Depth3Test.sh
[0.000s] readytorun.DynamicMethodGCStress.DynamicMethodGCStress.DynamicMethodGCStress
    DynamicMethodGCStress.sh
[0.000s] GC.LargeMemory.API.gc.reregisterforfinalize.reregisterforfinalize
    reregisterforfinalize.sh
[0.000s] GC.LargeMemory.API.gc.getgeneration.getgeneration
    getgeneration.sh
[0.000s] GC.LargeMemory.API.gc.collect.collect
    collect.sh
[0.000s] GC.LargeMemory.Allocation.finalizertest.finalizertest
    finalizertest.sh
[0.000s] GC.Regressions.dev10bugs.536168.536168.536168
    536168.sh
[0.000s] GC.Regressions.Github.Runtime_76219.Runtime_76219.Runtime_76219
    Runtime_76219.sh
[0.000s] GC.Features.BackgroundGC.foregroundgc.foregroundgc
    foregroundgc.sh
[0.000s] GC.Features.LOHFragmentation.lohfragmentation.lohfragmentation
    lohfragmentation.sh
[0.000s] GC.Coverage.271010.271010
    271010.sh
[0.000s] baseservices.threading.regressions.2164.foreground-shutdown.foreground-shutdown
    foreground-shutdown.sh
[0.000s] baseservices.mono.runningmono.runningmono
    runningmono.sh
[0.000s] baseservices.typeequivalence.signatures.nopiatestil.nopiatestil
    nopiatestil.sh
[0.000s] baseservices.typeequivalence.istypeequivalent.istypeequivalent.istypeequivalent
    istypeequivalent.sh
[0.000s] baseservices.finalization.CriticalFinalizer.CriticalFinalizer
    CriticalFinalizer.sh
[0.000s] baseservices.exceptions.stackoverflow.stackoverflowtester.stackoverflowtester
    stackoverflowtester.sh
[0.000s] baseservices.exceptions.StackTracePreserve.StackTracePreserveTests.StackTracePreserveTests
    StackTracePreserveTests.sh

@build-analysis build-analysis bot mentioned this pull request Jun 18, 2024
Closed
3 tasks
@risc-vv
Copy link

risc-vv commented Jun 18, 2024

RISC-V test results for starfive-prio1-checked (Checked build): 9404 / 9405 (99.99%)

details

GIT: 8ca3903
Build mode: Checked
Links:

  1. tests_results.xml
  2. tests_output.tar.gz /pipelines//starfive-prio1-checked/12/run-tests/1/ALL/testoutput/test_datails.Checked.tar.gz
  3. coreclr/prio1 tests binary /pipelines//build-runtime-checked/33/build-tests-prio1/1/build/coreclr.Checked.prio1.tar.gz
  4. clr+libs+host binary /pipelines//build-runtime-checked/33/build-core/1/build/artifacts.Checked.tar.gz
  5. testhost binary /pipelines//build-runtime-checked/33/build-core/1/build/testhost.Checked.tar.gz

=======================
      passed: 9404
      failed: 1
     skipped: 42
      killed: 0
------------------------
  TOTAL libs: 9447
 TOTAL tests: 9447
   REAL time: 2h 51min 57s 701ms
=======================
failed tests 
[710.110s] readytorun.coreroot_determinism.coreroot_determinism.coreroot_determinism
    coreroot_determinism.sh
    [exitcode-  1]: unknown error
killed tests
skipped tests 
[0.000s] readytorun.DynamicMethodGCStress.DynamicMethodGCStress.DynamicMethodGCStress
    DynamicMethodGCStress.sh
[0.000s] readytorun.GenericCycleDetection.Depth3Test.Depth3Test
    Depth3Test.sh
[0.000s] GC.Features.LOHFragmentation.lohfragmentation.lohfragmentation
    lohfragmentation.sh
[0.000s] GC.Features.BackgroundGC.foregroundgc.foregroundgc
    foregroundgc.sh
[0.000s] GC.Coverage.271010.271010
    271010.sh
[0.000s] GC.LargeMemory.Allocation.finalizertest.finalizertest
    finalizertest.sh
[0.000s] GC.LargeMemory.API.gc.collect.collect
    collect.sh
[0.000s] GC.LargeMemory.API.gc.reregisterforfinalize.reregisterforfinalize
    reregisterforfinalize.sh
[0.000s] GC.LargeMemory.API.gc.getgeneration.getgeneration
    getgeneration.sh
[0.000s] GC.Regressions.dev10bugs.536168.536168.536168
    536168.sh
[0.000s] GC.Regressions.Github.Runtime_76219.Runtime_76219.Runtime_76219
    Runtime_76219.sh
[0.000s] JIT.Regression.CLR-x86-JIT.V1-M11-Beta1.b41391.b41391.b41391
    b41391.sh
[0.000s] JIT.Regression.CLR-x86-JIT.V1-M12-Beta2.b37646.b37646.b37646
    b37646.sh
[0.000s] JIT.Regression.CLR-x86-JIT.V1-M12-Beta2.b31746.b31746.b31746
    b31746.sh
[0.000s] JIT.Regression.CLR-x86-JIT.V1-M12-Beta2.b41852.b41852.b41852
    b41852.sh
[0.000s] JIT.Regression.CLR-x86-JIT.V1-M09.5-PDC.b16423.b16423.b16423
    b16423.sh
[0.000s] JIT.Regression.JitBlue.Runtime_57606.Runtime_57606.Runtime_57606
    Runtime_57606.sh
[0.000s] JIT.Regression.CLR-x86-EJIT.V1-M12-Beta2.b26323.b26323.b26323
    b26323.sh
[0.000s] JIT.Directed.arglist.vararg_TargetUnix.vararg_TargetUnix
    vararg_TargetUnix.sh
[0.000s] JIT.Directed.rvastatics.RVAOrderingTest.RVAOrderingTest
    RVAOrderingTest.sh
[0.000s] JIT.Directed.PREFIX.volatile.1.arglist_Target_64BIT_volatile.arglist_Target_64BIT_volatile
    arglist_Target_64BIT_volatile.sh
[0.000s] JIT.Directed.PREFIX.unaligned.4.arglist_Target_64BIT_unaligned_4.arglist_Target_64BIT_unaligned_4
    arglist_Target_64BIT_unaligned_4.sh
[0.000s] JIT.Directed.PREFIX.unaligned.2.arglist_Target_64BIT_unaligned_2.arglist_Target_64BIT_unaligned_2
    arglist_Target_64BIT_unaligned_2.sh
[0.000s] JIT.Directed.PREFIX.unaligned.1.arglist_Target_64BIT_unaligned_1.arglist_Target_64BIT_unaligned_1
    arglist_Target_64BIT_unaligned_1.sh
[0.000s] JIT.jit64.mcc.interop.mcc_i00.mcc_i00
    mcc_i00.sh
[0.000s] JIT.opt.SSA.MemorySsa.MemorySsa
    MemorySsa.sh
[0.000s] JIT.opt.ValueNumbering.ExposedLocalsNumbering.ExposedLocalsNumbering
    ExposedLocalsNumbering.sh
[0.000s] JIT.Methodical.Coverage.arglist_pos.arglist_pos
    arglist_pos.sh
[0.000s] JIT.Methodical.refany.seq_d.seq_d
    seq_d.sh
[0.000s] JIT.Methodical.refany.seq_r.seq_r
    seq_r.sh
[0.000s] Loader.binding.tracing.BinderTracingTest.Basic.BinderTracingTest.Basic
    BinderTracingTest.Basic.sh
[0.000s] Interop.MonoAPI.MonoMono.Thunks.Thunks
    Thunks.sh
[0.000s] Interop.MonoAPI.MonoMono.PInvokeDetach.PInvokeDetach
    PInvokeDetach.sh
[0.000s] Interop.MonoAPI.MonoMono.InstallEHCallback.InstallEHCallback
    InstallEHCallback.sh
[0.000s] tracing.eventpipe.eventsourceerror.eventsourceerror.eventsourceerror
    eventsourceerror.sh
[0.000s] baseservices.finalization.CriticalFinalizer.CriticalFinalizer
    CriticalFinalizer.sh
[0.000s] baseservices.mono.runningmono.runningmono
    runningmono.sh
[0.000s] baseservices.threading.regressions.2164.foreground-shutdown.foreground-shutdown
    foreground-shutdown.sh
[0.000s] baseservices.exceptions.stackoverflow.stackoverflowtester.stackoverflowtester
    stackoverflowtester.sh
[0.000s] baseservices.exceptions.StackTracePreserve.StackTracePreserveTests.StackTracePreserveTests
    StackTracePreserveTests.sh
[0.000s] baseservices.typeequivalence.istypeequivalent.istypeequivalent.istypeequivalent
    istypeequivalent.sh
[0.000s] baseservices.typeequivalence.signatures.nopiatestil.nopiatestil
    nopiatestil.sh

jakobbotsch
jakobbotsch approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jakobbotsch jakobbotsch merged commit aa0a7e9 into dotnet:main Jun 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

@tomeksowi tomeksowi

Labels

arch-riscv Related to the RISC-V architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tomeksowi @risc-vv @jakobbotsch @clamp03