Skip to content

Extend MediaTypeNames #103575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2024
Merged

Extend MediaTypeNames #103575

merged 1 commit into from
Jun 17, 2024

Conversation

@CollinAlpert
Copy link
Contributor

@CollinAlpert CollinAlpert commented Jun 17, 2024

Add some media types to System.Net.Mime.MediaTypeNames.

Fixes #95446

@ghost
Copy link

ghost commented Jun 17, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost
Copy link

ghost commented Jun 17, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 17, 2024
ManickaP
ManickaP approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

This was referenced Jun 17, 2024
Closed
Closed
Open
Closed
wfurt
wfurt approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt wfurt merged commit ac996f3 into dotnet:main Jun 17, 2024
@CollinAlpert CollinAlpert deleted the issue-95446 branch June 18, 2024 06:13
@karelz karelz added this to the 9.0.0 milestone Jun 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ManickaP ManickaP ManickaP approved these changes

@wfurt wfurt wfurt approved these changes

Assignees

No one assigned

Labels

area-System.Net community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add multipart/related to MediaTypeNames.Multipart

4 participants

@CollinAlpert @ManickaP @wfurt @karelz