Add Base64Fuzzer to the repo #103011
Merged
Add Base64Fuzzer to the repo #103011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buyaa-n
requested review from
GrabYourPitchforks,
MihaZupan,
bartonjs,
stephentoub and
tannergooding
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
4 tasks
bartonjs
reviewed
Jun 3, 2024
Member
|
@MihuBot fuzz base64 |
MihaZupan
approved these changes
Jun 4, 2024
Member
MihaZupan
left a comment
MihaZupan
left a comment
There was a problem hiding this comment.
The fuzzing part LGTM.
The System.Buffers area may want to check if this is covering all the paths we care about for Base64.
This was referenced Jun 4, 2024
Open
Contributor
Author
Well, Base64 doesn't have so many APIs, and this PR covers all those APIs. There could be scenario where whitespaces involved in decoding, but I am not sure how to tell the fuzzer to generate valid base64 bytes with whitespaces, looks there is no way except insert white spaces manually after encoding. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Base64Fuzzer to the repo
Related to #102364 (review)