Revert uses of Unsafe.BitCast with spans to unblock mono #102998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
lewing
approved these changes
Jun 3, 2024
AaronRobinsonMSFT
approved these changes
Jun 3, 2024
|
Could you please revert it in tests too? |
lambdageek
added a commit
to lambdageek/runtime
that referenced
this pull request
Jun 4, 2024
…net#102998)" This reverts commit c286a8e.
lambdageek
added a commit
that referenced
this pull request
Jun 9, 2024
…s up front (#103052) * [interp] handle box + brtrue/brfalse pattern for byreflike types In cases where we don't do cprop and deadce (for example if `mono_interp_opt` is 0 because we're debugging) don't emit a box_vt opcode before a branch. Instead just emit a constant true Fixes #102988 * Revert "Revert uses of Unsafe.BitCast with spans to unblock mono (#102998)" This reverts commit c286a8e. Reverts #102998 * remove the box byreflike retry code we handle box byreflike code patterns directly now * handle box;isinst;{brtrue|brfalse|unbox.any} IL patterns * Add test locking down mismatched box;isinst;unbox.any pattern * remove the mismatch case in the interp. throw IPE at execution time * Update src/tests/Loader/classloader/generics/ByRefLike/Validate.cs Co-authored-by: Aaron Robinson <[email protected]> --------- Co-authored-by: Aaron Robinson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#102988 (comment)