Skip to content

JIT: Propagate LCL_ADDR nodes during local morph #102808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 31, 2024
Merged

JIT: Propagate LCL_ADDR nodes during local morph #102808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
781cc88
JIT: Propagate LCL_ADDR nodes during local morph
jakobbotsch May 29, 2024
cc96dff
Fixes
jakobbotsch May 29, 2024
2186b73
Another fix
jakobbotsch May 29, 2024
32d3cd0
Add a test
jakobbotsch May 29, 2024
9ce5f1c
Switch to `lvHasLdAddrOp`
jakobbotsch May 29, 2024
543d223
Simplify, add range jit option
jakobbotsch May 30, 2024
392e7aa
Simple optimization
jakobbotsch May 30, 2024
5ec2c48
Add some JITDUMP when dropping assertions; avoid adding to the map un…
jakobbotsch May 31, 2024
3549980
Run jit-format
jakobbotsch May 31, 2024
33127cf
Minor nits
jakobbotsch May 31, 2024
2b51d32
Propagate madeChanges
jakobbotsch May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/coreclr/jit/compiler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6756,6 +6756,8 @@ class Compiler

PhaseStatus fgMarkAddressExposedLocals();
void fgSequenceLocals(Statement* stmt);
bool fgExposeUnpropagatedLocals(bool propagatedAny, class LocalEqualsLocalAddrAssertions* assertions);
void fgExposeLocalsInBitVec(BitVec_ValArg_T bitVec);

PhaseStatus PhysicalPromotion();

Expand Down
1 change: 1 addition & 0 deletions src/coreclr/jit/jitconfigvalues.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,6 +567,7 @@ OPT_CONFIG_STRING(JitOnlyOptimizeRange,
OPT_CONFIG_STRING(JitEnablePhysicalPromotionRange, W("JitEnablePhysicalPromotionRange"))
OPT_CONFIG_STRING(JitEnableCrossBlockLocalAssertionPropRange, W("JitEnableCrossBlockLocalAssertionPropRange"))
OPT_CONFIG_STRING(JitEnableInductionVariableOptsRange, W("JitEnableInductionVariableOptsRange"))
OPT_CONFIG_STRING(JitEnableLocalAddrPropagationRange, W("JitEnableLocalAddrPropagationRange"))

OPT_CONFIG_INTEGER(JitDoSsa, W("JitDoSsa"), 1) // Perform Static Single Assignment (SSA) numbering on the variables
OPT_CONFIG_INTEGER(JitDoValueNumber, W("JitDoValueNumber"), 1) // Perform value numbering on method expressions
Expand Down
Loading