Skip to content

Conversation

@lewing
Copy link
Member

@lewing lewing commented May 23, 2024

Now that installer is not producing the installer we need use sdk versions here. We should probably remove the subscription from main once this is verified as well.

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 23, 2024
lewing added 2 commits May 23, 2024 13:56
Remove installer reference from Version.Details.xml
@lewing lewing requested review from akoeplinger, maraf and steveisok May 23, 2024 18:57
@lewing lewing added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label May 23, 2024
@lewing lewing marked this pull request as draft May 23, 2024 19:39
@lewing lewing added area-Workloads Workloads like wasm-tools and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 23, 2024
@lewing lewing removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label May 24, 2024
@lewing lewing marked this pull request as ready for review May 24, 2024 14:43
@lewing lewing merged commit 8ec2649 into main May 24, 2024
@lewing lewing deleted the sdk-flow-not-installer branch May 24, 2024 14:43
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
* Use Sdk not installer flow for wasm build tests

* Update Version.Details.xml

Remove installer reference from Version.Details.xml

* Update Versions.props

* Update versions
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Workloads Workloads like wasm-tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants