You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to #102461, and part of #9304. Compacting blocks after establishing an RPO-based layout, but before moving backward jumps to fall into their successors, can enable more opportunities for branch removal (example). Here are the diffs on Windows x64: gist. TP impact is minimal, ranging from -0.05% to +0.01%.
cc @dotnet/jit-contrib, @jakobbotsch PTAL. I'm ok with us deciding to merge this now, or some time after merging #102343. Thanks!
In fgDoReversePostOrderLayout, we build an array of call-finally pairs before reordering any blocks, so we can easily fix these pairs up later. After setting up the RPO layout, but before fixing the call-finally pairs, we call fgMoveBackwardJumpsToSuccessors, which can compact BBJ_ALWAYS predecessors into BBJ_CALLFINALLY successors, thus invalidating the block pointers in the array. Doing the call-finally fixups before calling fgMoveBackwardJumpsToSuccessors easily fixes this.
Follow-up to dotnet#102461, and part of dotnet#9304. Compacting blocks after establishing an RPO-based layout, but before moving backward jumps to fall into their successors, can enable more opportunities for branch removal; see dotnet#9304 for one such example.
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
Follow-up to dotnet#102461, and part of dotnet#9304. Compacting blocks after establishing an RPO-based layout, but before moving backward jumps to fall into their successors, can enable more opportunities for branch removal; see dotnet#9304 for one such example.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghost
added
the
area-CodeGen-coreclr
Follow-up to #102461, and part of #9304. Compacting blocks after establishing an RPO-based layout, but before moving backward jumps to fall into their successors, can enable more opportunities for branch removal (example). Here are the diffs on Windows x64: gist. TP impact is minimal, ranging from -0.05% to +0.01%.
cc @dotnet/jit-contrib, @jakobbotsch PTAL. I'm ok with us deciding to merge this now, or some time after merging #102343. Thanks!