Skip to content

[browser] optimize condition on mono_log_debug #102184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2024
Merged

[browser] optimize condition on mono_log_debug #102184

merged 3 commits into from
May 15, 2024

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented May 14, 2024

No description provided.

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels May 14, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone May 14, 2024
@pavelsavara pavelsavara self-assigned this May 14, 2024
@pavelsavara pavelsavara requested review from kg and maraf May 14, 2024 09:37
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented May 14, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara pavelsavara mentioned this pull request May 14, 2024
Closed
@build-analysis build-analysis bot mentioned this pull request May 14, 2024
Open
kg
kg approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@kg kg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@kg
Copy link
Member

kg commented May 14, 2024 •
edited by pavelsavara
Loading

Log

[warning] MONO_WASM: Failed to import library initializer '../WasmBasicTestApp.lib.module.js': ReferenceError: mono_always_log_debug is not defined
[warning] MONO_WASM: mono_exit A failed ReferenceError: mono_always_log_debug is not defined
    at et (http://127.0.0.1:36513/_framework/dotnet.js:3:21128)
    at Object.create (http://127.0.0.1:36513/_framework/dotnet.js:3:38329)
    at async http://127.0.0.1:36513/main.js:89:71
[error] MONO_WASM: mono_always_log_debug is not defined
ReferenceError: mono_always_log_debug is not defined
    at at (http://127.0.0.1:36513/_framework/dotnet.js:3:33959)
    at http://127.0.0.1:36513/_framework/dotnet.js:3:31339
    at async http://127.0.0.1:36513/_framework/dotnet.js:3:38276
    at async Object.create (http://127.0.0.1:36513/_framework/dotnet.js:3:38045)
    at async http://127.0.0.1:36513/main.js:89:71
[info] WASM EXIT 1
[ERROR] PageError: ReferenceError: mono_always_log_debug is not defined
    at at (http://127.0.0.1:36513/_framework/dotnet.js:3:33959)
    at http://127.0.0.1:36513/_framework/dotnet.js:3:31339
    at async http://127.0.0.1:36513/_framework/dotnet.js:3:38276
    at async Object.create (http://127.0.0.1:36513/_framework/dotnet.js:3:38045)
    at async http://127.0.0.1:36513/main.js:89:71

@pavelsavara
fix
d1ddbf5
@pavelsavara
Merge branch 'main' into browser_debug_log_rewrite
0d62d72 
# Conflicts:
#	src/mono/browser/runtime/assets.ts
@pavelsavara pavelsavara marked this pull request as ready for review May 15, 2024 10:16
@pavelsavara pavelsavara requested a review from lewing as a code owner May 15, 2024 10:16
@pavelsavara
Copy link
Member Author

pavelsavara commented May 15, 2024

MT CI fails with #102196

@pavelsavara
Copy link
Member Author

pavelsavara commented May 15, 2024

/ba-g MT CI fails with #102196

@pavelsavara pavelsavara merged commit ddff593 into dotnet:main May 15, 2024
@pavelsavara pavelsavara deleted the browser_debug_log_rewrite branch May 15, 2024 12:48
@build-analysis build-analysis bot mentioned this pull request May 15, 2024
Closed
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@pavelsavara @Ruihan-Yin
[browser] optimize condition on mono_log_debug (dotnet#102184)
40f8837
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kg kg kg approved these changes

@maraf maraf Awaiting requested review from maraf

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@pavelsavara @kg