Fix S.D.Tracing testapps with AOT #101373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe what the test is doing is not trim safe and only succeeds due to lucky IL trimming implementation details.
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
This was referenced Apr 22, 2024
eerhardt
approved these changes
Apr 22, 2024
| public TestEventSource() : base(EventSourceSettings.EtwSelfDescribingEventFormat) { } | ||
|
|
||
| [Event(1)] | ||
| [DynamicDependency(DynamicallyAccessedMemberTypes.PublicProperties, typeof(TestSubData))] |
Member
There was a problem hiding this comment.
I assume this worked with ILLink because the property was accessed in IL (both the getter and the setter).
Member
Author
There was a problem hiding this comment.
Yep, calling the getter or setter keeps the property right now.
The property could still be removed in theory since what is used is just getter/setter method, but illink never does it right now (it could do it if DebuggerSupport=false, since it makes debugging sub-optimal). It's what I called "lucky IL trimming implementation details".
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
I believe what the test is doing is not trim safe and only succeeds due to lucky IL trimming implementation details.
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
I believe what the test is doing is not trim safe and only succeeds due to lucky IL trimming implementation details.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #101228.
I believe what the test is doing is not trim safe and only succeeds due to lucky IL trimming implementation details.