Skip to content

Disable binder tracing test under gcstress #100798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2024
+6 −14
Merged

Disable binder tracing test under gcstress #100798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/tests/Loader/binding/tracing/BinderTracingTest.Basic.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<!-- TestAssemblyLoadContext.Load called from the finalizer -->
<UnloadabilityIncompatible>true</UnloadabilityIncompatible>
<!-- Dynamic assembly loads -->
<NativeAotIncompatible>true</NativeAotIncompatible>
</PropertyGroup>
<ItemGroup>
<Compile Include="BinderTracingTest.Basic.cs" />
<Compile Include="BinderTracingTest.DefaultProbing.cs" />
Expand Down
5 changes: 0 additions & 5 deletions src/tests/Loader/binding/tracing/BinderTracingTest.ResolutionFlow.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<!-- Test creates non-collectible AssemblyLoadContext -->
<UnloadabilityIncompatible>true</UnloadabilityIncompatible>
<!-- Dynamic assembly loads -->
<NativeAotIncompatible>true</NativeAotIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
<IlasmRoundTripIncompatible>true</IlasmRoundTripIncompatible>
</PropertyGroup>
<ItemGroup>
Expand Down
3 changes: 0 additions & 3 deletions src/tests/Loader/binding/tracing/BinderTracingTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,6 @@ public static bool RunAllTests()
foreach (var method in methods)
{
BinderTestAttribute attribute = method.GetCustomAttribute<BinderTestAttribute>();
if (attribute.Isolate && Environment.GetEnvironmentVariable("DOTNET_GCStress") != null)
continue;

bool success = attribute.Isolate
? RunTestInSeparateProcess(method)
: RunSingleTest(method);
Expand Down
6 changes: 6 additions & 0 deletions src/tests/Loader/binding/tracing/BinderTracingTest.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@
<!-- Requires explicit Main as it implements command-line parameters for local testing purposes. -->
<RequiresProcessIsolation>true</RequiresProcessIsolation>
<ReferenceXUnitWrapperGenerator>false</ReferenceXUnitWrapperGenerator>
<!-- Test creates non-collectible AssemblyLoadContext -->
<UnloadabilityIncompatible>true</UnloadabilityIncompatible>
<!-- Dynamic assembly loads -->
<NativeAotIncompatible>true</NativeAotIncompatible>
<!-- Tracing tests routinely time out with gcstress -->
<GCStressIncompatible>true</GCStressIncompatible>
</PropertyGroup>
<ItemGroup>
<Compile Include="BinderTracingTest.cs" />
Expand Down