-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Remove invalid GCPROTECT for duplicate slot
#100787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove invalid GCPROTECT for duplicate slot
#100787
Conversation
|
/azp list |
|
/azp run runtime-coreclr gcstress0x3-gcstress0xc |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Failure - #94390 |
|
/backport to release/staging-8.0 |
|
Started backporting to release/staging-8.0: https://github.com/dotnet/runtime/actions/runs/15887123907 |
|
@elinor-fung an error occurred while backporting to "release/staging-8.0", please check the run log for details! Error: The specified backport target branch "release/staging-8.0" wasn't found in the repo. |
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/15887172637 |
|
Do we ever run the test with some GC stress mode? I've added detection of double reporting that's enabled when GC stress is enabled (Or it can be enabled manually by |
This testing wasn't running. When I did force it to run under GC Stress, the infrastructure that you did mention caught it. This code path is executed in tests that aren't GC Stress compatible due to how long they run. |
|
Wasn't the original issue reported via a GC stress run for |
You're right. I specifically remember a converstion directly or indirectly with JanV about his detection of double reporting. It is possible I'm misremembering whether it was during my investigation or after, but I do know the detection system was discussed around the time I put up the PR. |
Fixes #100739
/cc @janvorli @dotnet/interop-contrib