-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[wasm] emscripten bump 3.1.56 #100334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] emscripten bump 3.1.56 #100334
Changes from 4 commits
e52f7df
a91ec44
d23f6fa
9848b92
50dfb72
aca6c58
f229a30
f917ea6
a7c4e55
0b030c1
6a0057f
6cde92a
1721779
fe1e5c6
3f8834f
123767a
e3b1316
7d6edc3
15bd585
92b4559
d7b1d52
3593c41
4530edf
200cf3b
6e86cc3
02fb272
c313fa5
253ebf9
0d7708b
8a12f44
fc6ad97
683bd51
b15fd5c
9ae3c2f
60a4799
4dadd6d
3bd6bfb
16866a1
d53aaa3
6765913
4c69c36
c268a87
d1d8619
abe9b00
63087a5
d5a0bc4
5d9a6d2
8505fd5
3fe1e1f
b2655bf
ba1ad20
009e371
9e0d5ce
061f2b5
8ed7bf9
d665bfa
fdbb1f2
ddc4698
e6426d2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 3.1.34 | ||
| 3.1.56 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| if (_nativeModuleLoaded) throw new Error("Native module already loaded"); | ||
| _nativeModuleLoaded = true; | ||
| createDotnetRuntime = Module = createDotnetRuntime(Module); | ||
| createDotnetRuntime = Module = moduleArg(Module); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -71,7 +71,8 @@ public static bool ShouldFilterCandidate( | |
| ".ts" when fromMonoPackage && fileName == "dotnet.d" => "dotnet type definition is not used by Blazor", | ||
| ".map" when !emitSourceMap && fromMonoPackage && (fileName == "dotnet.js" || fileName == "dotnet.runtime.js") => "source map file is not published", | ||
| ".ts" when fromMonoPackage && fileName == "dotnet-legacy.d" => "dotnet type definition is not used by Blazor", | ||
| ".js" when assetType == "native" && !(dotnetJsSingleThreadNames.Contains(fileName) || (enableThreads && fileName == "dotnet.native.worker")) => $"{fileName}{extension} is not used by Blazor", | ||
| ".js" when assetType == "native" && !dotnetJsSingleThreadNames.Contains(fileName) => $"{fileName}{extension} is not used by Blazor", | ||
| ".mjs" when assetType == "native" && !(enableThreads && fileName == "dotnet.native.worker") => $"{fileName}{extension} is not used by Blazor", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All the code in this project is used when targeting downlevel versions and we don't have it covered with tests. Threading is not supported there, but it would be good to not break it. |
||
| ".pdb" when !copySymbols => "copying symbols is disabled", | ||
| ".symbols" when fromMonoPackage => "extension .symbols is not required.", | ||
| _ => null | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,7 +54,7 @@ static void AddDictionary(StringBuilder sb, Dictionary<string, string>? res) | |
| public Dictionary<string, string>? GetNativeResourceTargetInBootConfig(BootJsonData bootConfig, string resourceName) | ||
| { | ||
| string resourceExtension = Path.GetExtension(resourceName); | ||
| if (resourceName.StartsWith("dotnet.native.worker", StringComparison.OrdinalIgnoreCase) && string.Equals(resourceExtension, ".js", StringComparison.OrdinalIgnoreCase)) | ||
| if (resourceName.StartsWith("dotnet.native.worker", StringComparison.OrdinalIgnoreCase) && string.Equals(resourceExtension, ".mjs", StringComparison.OrdinalIgnoreCase)) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if this is code that impacts Net8, it still needs to consider |
||
| return bootConfig.resources.jsModuleWorker ??= new(); | ||
| else if (resourceName.StartsWith("dotnet.native", StringComparison.OrdinalIgnoreCase) && string.Equals(resourceExtension, ".js", StringComparison.OrdinalIgnoreCase)) | ||
| return bootConfig.resources.jsModuleNative ??= new(); | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.