Skip to content

[QUIC] Move 0 byte read before semaphore release #100128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2024
+6 −4
Merged

[QUIC] Move 0 byte read before semaphore release #100128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/libraries/System.Net.Quic/tests/FunctionalTests/QuicStreamTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1249,11 +1249,12 @@ await RunClientServer(
{
await stream.WritesClosed;
}
serverSem.Release();
await clientSem.WaitAsync();

var _ = await stream.ReadAsync(new byte[0]);

serverSem.Release();
await clientSem.WaitAsync();

if (closeServer)
{
expectedError = QuicError.OperationAborted;
Expand Down Expand Up @@ -1281,11 +1282,12 @@ await RunClientServer(
{
await stream.WritesClosed;
}
clientSem.Release();
await serverSem.WaitAsync();

var _ = await stream.ReadAsync(new byte[0]);

clientSem.Release();
await serverSem.WaitAsync();

if (!closeServer)
{
expectedError = QuicError.OperationAborted;
Expand Down