Skip to content

[browser] Fix filtering compressed assets for pdb during publish #100016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 21, 2024
Merged

[browser] Fix filtering compressed assets for pdb during publish #100016

merged 2 commits into from
Mar 21, 2024

Conversation

@maraf
Copy link
Member

@maraf maraf commented Mar 20, 2024

Remove compressed alternatives from publish when original pdb asset is filtered out.

Fixes #99917

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Mar 20, 2024
@maraf maraf added this to the 9.0.0 milestone Mar 20, 2024
@maraf maraf requested a review from akoeplinger March 20, 2024 13:29
@maraf maraf self-assigned this Mar 20, 2024
@maraf maraf requested a review from ilonatommy as a code owner March 20, 2024 13:29
@maraf maraf requested a review from lewing March 20, 2024 13:29
@build-analysis build-analysis bot mentioned this pull request Mar 20, 2024
Closed
@maraf maraf merged commit 3caa596 into dotnet:main Mar 21, 2024
@maraf maraf deleted the BrowserSdkCompressedPdb branch March 21, 2024 15:55
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@ilonatommy ilonatommy ilonatommy approved these changes

@lewing lewing Awaiting requested review from lewing

Assignees

@maraf maraf

Labels

arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

[browser] ComputeWasmPublishAssets incorrectly upgrades compressed asset versions of assets that are not included as part of publish.

3 participants

@maraf @akoeplinger @ilonatommy