Code coverage failing for corelib

[stephentoub]

Trying to do code coverage on corelib (e.g. do code coverage for System.Collections.Concurrent's tests) results in failure:

Unhandled exception. System.ArgumentException: Value does not fall within the expected range.
     at System.Runtime.CompilerServices.RuntimeHelpers.GetSpanDataFrom(RuntimeFieldHandle fldHandle, RuntimeTypeHandle targetTypeHandle, Int32& count)
     at System.Runtime.CompilerServices.RuntimeHelpers.CreateSpan[T](RuntimeFieldHandle fldHandle) in D:\repos\runtime\src\libraries\System.Private.CoreLib\src\System\Runtime\CompilerServices\RuntimeHelpers.cs:line 100
     at System.DateTime.get_DaysToMonth365() in D:\repos\runtime\src\libraries\System.Private.CoreLib\src\System\DateTime.cs:line 124
     at System.DateTime.CreateDateTimeFromSystemTime(SYSTEMTIME& time, UInt64 hundredNanoSecond) in D:\repos\runtime\src\libraries\System.Private.CoreLib\src\System\DateTime.Windows.cs:line 112
     at System.DateTime.UpdateLeapSecondCacheAndReturnUtcNow() in D:\repos\runtime\src\libraries\System.Private.CoreLib\src\System\DateTime.Windows.cs:line 247
     at System.DateTime.get_UtcNow() in D:\repos\runtime\src\libraries\System.Private.CoreLib\src\System\DateTime.Windows.cs:line 34
     at System.DateTimeOffset.get_UtcNow() in D:\repos\runtime\src\libraries\System.Private.CoreLib\src\System\DateTimeOffset.cs:line 340
     at Xunit.XunitFilters.ChangeTrackingHashSet`1..ctor(IEqualityComparer`1 comparer) in /_/src/xunit.runner.utility/Project/XunitFilters.cs:line 280
     at Xunit.XunitFilters..ctor() in /_/src/xunit.runner.utility/Project/XunitFilters.cs:line 33
     at Xunit.XunitProject..ctor() in /_/src/xunit.runner.utility/Project/XunitProject.cs:line 17
     at Xunit.ConsoleClient.CommandLine.GetProjectFile(List`1 assemblies) in /_/src/Microsoft.DotNet.XUnitConsoleRunner/src/CommandLine.cs:line 85
     at Xunit.ConsoleClient.CommandLine.Parse(Predicate`1 fileExists) in /_/src/Microsoft.DotNet.XUnitConsoleRunner/src/CommandLine.cs:line 234
     at Xunit.ConsoleClient.CommandLine..ctor(String[] args, Predicate`1 fileExists) in /_/src/Microsoft.DotNet.XUnitConsoleRunner/src/CommandLine.cs:line 21
     at Xunit.ConsoleClient.CommandLine.Parse(String[] args) in /_/src/Microsoft.DotNet.XUnitConsoleRunner/src/CommandLine.cs:line 110
     at Xunit.ConsoleClient.ConsoleRunner.EntryPoint(String[] args) in /_/src/Microsoft.DotNet.XUnitConsoleRunner/src/ConsoleRunner.cs:line 31
     at Xunit.ConsoleClient.Program.Main(String[] args) in /_/src/Microsoft.DotNet.XUnitConsoleRunner/src/Program.cs:line 16

Failure from RuntimeHelpers.CreateSpan like this typically means the field being referenced isn't properly aligned. Does the coverlet collector do anything that might impact such alignment?

cc: @ViktorHofer, @MarcoRossignoli

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[MarcoRossignoli]

Last release was done https://github.com/coverlet-coverage/coverlet/blob/master/Documentation/Changelog.md#release-date-2022-10-29 last October, has something changed?
Coverlet is inserting a tracker and a call to an helper method

@stephentoub can you try to put a sleep in some test and check with ILSpy is something is wrong?

[ViktorHofer]

We actually use the 3.1.2 version which is a year old, so it's likely a change in our repo that caused this.

runtime/.config/dotnet-tools.json

Line 6 in bd54093

"version": "3.1.2",

[stephentoub]

Coverlet is inserting a tracker and a call to an helper method

Is the rewritten corelib persisted to disk somewhere?

[stephentoub]

Coverlet is inserting a tracker and a call to an helper method

What library (and what version of that library) is it using to rewrite the assembly?

[stephentoub]

My guess is coverlet is using cecil and a version of it that lacks jbevain/cecil#817 and/or jbevain/cecil#888.
cc: @sbomer

[MarcoRossignoli]

What library (and what version of that library) is it using to rewrite the assembly?

<PackageReference Update="Mono.Cecil" Version="0.11.1" />

Is the rewritten corelib persisted to disk somewhere?

Unfortunately not...if you can "block a test" adding some sleep it's possible copy/paste the instrumented lib somewhere for inspection. The instrumented lib is restored at the end of the tests and we don't have an option to preserve it.

[stephentoub]

@sbomer, it looks like Mono.Cecil hasn't published an update in a year and a half. How do we go about spurring that along? Anyone using any of the released versions with newer releases of Roslyn could end up having problems.

[sbomer]

Hopefully @jbevain can publish a new release soon - I opened jbevain/cecil#896 to request this.

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Trying to do code coverage on corelib (e.g. do code coverage for System.Collections.Concurrent's tests) results in failure:

Unhandled exception. System.ArgumentException: Value does not fall within the expected range.
     at System.Runtime.CompilerServices.RuntimeHelpers.GetSpanDataFrom(RuntimeFieldHandle fldHandle, RuntimeTypeHandle targetTypeHandle, Int32& count)
     at System.Runtime.CompilerServices.RuntimeHelpers.CreateSpan[T](RuntimeFieldHandle fldHandle) in D:\repos\runtime\src\libraries\System.Private.CoreLib\src\System\Runtime\CompilerServices\RuntimeHelpers.cs:line 100
     at System.DateTime.get_DaysToMonth365() in D:\repos\runtime\src\libraries\System.Private.CoreLib\src\System\DateTime.cs:line 124
     at System.DateTime.CreateDateTimeFromSystemTime(SYSTEMTIME& time, UInt64 hundredNanoSecond) in D:\repos\runtime\src\libraries\System.Private.CoreLib\src\System\DateTime.Windows.cs:line 112
     at System.DateTime.UpdateLeapSecondCacheAndReturnUtcNow() in D:\repos\runtime\src\libraries\System.Private.CoreLib\src\System\DateTime.Windows.cs:line 247
     at System.DateTime.get_UtcNow() in D:\repos\runtime\src\libraries\System.Private.CoreLib\src\System\DateTime.Windows.cs:line 34
     at System.DateTimeOffset.get_UtcNow() in D:\repos\runtime\src\libraries\System.Private.CoreLib\src\System\DateTimeOffset.cs:line 340
     at Xunit.XunitFilters.ChangeTrackingHashSet`1..ctor(IEqualityComparer`1 comparer) in /_/src/xunit.runner.utility/Project/XunitFilters.cs:line 280
     at Xunit.XunitFilters..ctor() in /_/src/xunit.runner.utility/Project/XunitFilters.cs:line 33
     at Xunit.XunitProject..ctor() in /_/src/xunit.runner.utility/Project/XunitProject.cs:line 17
     at Xunit.ConsoleClient.CommandLine.GetProjectFile(List`1 assemblies) in /_/src/Microsoft.DotNet.XUnitConsoleRunner/src/CommandLine.cs:line 85
     at Xunit.ConsoleClient.CommandLine.Parse(Predicate`1 fileExists) in /_/src/Microsoft.DotNet.XUnitConsoleRunner/src/CommandLine.cs:line 234
     at Xunit.ConsoleClient.CommandLine..ctor(String[] args, Predicate`1 fileExists) in /_/src/Microsoft.DotNet.XUnitConsoleRunner/src/CommandLine.cs:line 21
     at Xunit.ConsoleClient.CommandLine.Parse(String[] args) in /_/src/Microsoft.DotNet.XUnitConsoleRunner/src/CommandLine.cs:line 110
     at Xunit.ConsoleClient.ConsoleRunner.EntryPoint(String[] args) in /_/src/Microsoft.DotNet.XUnitConsoleRunner/src/ConsoleRunner.cs:line 31
     at Xunit.ConsoleClient.Program.Main(String[] args) in /_/src/Microsoft.DotNet.XUnitConsoleRunner/src/Program.cs:line 16

Failure from RuntimeHelpers.CreateSpan like this typically means the field being referenced isn't properly aligned. Does the coverlet collector do anything that might impact such alignment?

cc: @ViktorHofer, @MarcoRossignoli

Author:	stephentoub
Assignees:	-
Labels:	area-Infrastructure-libraries, untriaged, dev-innerloop
Milestone:	-