-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Closed
Description
Check all places where we call msquic and make sure we're not doing that in a lock since it can cause a deadlock.
For example:
runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs
Line 491 in 4d41173
| EnableReceive(); |
runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs
Line 486 in 4d41173
| ReceiveComplete(taken); |
Add asserts before msquic calls that the lock is not taken, e.g.:
runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs
Line 848 in 4d41173
| uint status = MsQuicApi.Api.StreamReceiveSetEnabledDelegate(_state.Handle, enabled: true); |