Assert failure `!success && GetLastError() == ERROR_INSUFFICIENT_BUFFER` on Windows 7

[jkoritzinsky]

When enabling testing on Windows 7, the following assert is being hit on 133 tests (test list included below):

runtime/src/coreclr/vm/threadsuspend.cpp

Line 1988 in 78d5d1c

_ASSERTE(!success && GetLastError() == ERROR_INSUFFICIENT_BUFFER);

Failing AzDO run: https://dev.azure.com/dnceng/public/_build/results?buildId=1283557&view=ms.vss-test-web.build-test-results-tab&runId=37905494&resultId=100188

Failing tests with Kusto query:

• tracing\eventpipe\eventsvalidation\GCEvents\GCEvents.cmd
• tracing\eventpipe\rundownvalidation\rundownvalidation\rundownvalidation.cmd
• tracing\eventpipe\gcdump\gcdump\gcdump.cmd
• tracing\eventpipe\eventsvalidation\ExceptionThrown_V1\ExceptionThrown_V1.cmd
• tracing\eventpipe\providervalidation\providervalidation\providervalidation.cmd
• tracing\eventpipe\eventsvalidation\GCFinalizers\GCFinalizers.cmd
• Regressions\coreclr\GitHub_45929\test45929\test45929.cmd
• readytorun\r2rdump\FrameworkTests\R2RDumpTests\R2RDumpTests.cmd
• readytorun\determinism\crossgen2determinism\crossgen2determinism.cmd
• readytorun\coreroot_determinism\coreroot_determinism\coreroot_determinism.cmd
• Loader\CollectibleAssemblies\ByRefLocals\ByRefLocals\ByRefLocals.cmd
• GC\Scenarios\DoublinkList\dlbigleakthd_v2\dlbigleakthd_v2.cmd
• GC\Scenarios\SingLinkList\singlinkstay\singlinkstay.cmd
• GC\Scenarios\DoublinkList\dlstack\dlstack.cmd
• GC\Scenarios\DoublinkList\dlbigleak\dlbigleak.cmd
• GC\Scenarios\FinalizeTimeout\FinalizeTimeout\FinalizeTimeout.cmd
• GC\Scenarios\StringCreator\stringcreator\stringcreator.cmd
• GC\Scenarios\ReflectObj\reflectobj\reflectobj.cmd
• GC\Scenarios\DoublinkList\doublinkstay\doublinkstay.cmd
• GC\Scenarios\FinalNStruct\nstructtun\nstructtun.cmd
• GC\Scenarios\ServerModel\servermodel\servermodel.cmd
• GC\Scenarios\DoublinkList\dlbigleakthd\dlbigleakthd.cmd
• GC\Scenarios\RanCollect\rancollect\rancollect.cmd
• GC\Scenarios\DoublinkList\doublinkgen\doublinkgen.cmd
• GC\Regressions\v2.0-rtm\494226\494226\494226.cmd
• GC\Regressions\v2.0-beta1\149926\149926\149926.cmd
• GC\Regressions\v2.0-beta2\445488\445488\445488.cmd
• GC\Regressions\v2.0-beta2\460373\460373\460373.cmd
• GC\Features\HeapExpansion\bestfit_1\bestfit_1.cmd
• GC\Features\HeapExpansion\plug\plug.cmd
• GC\Features\HeapExpansion\pluggaps\pluggaps.cmd
• GC\Features\HeapExpansion\bestfit-finalize\bestfit-finalize.cmd
• GC\Features\HeapExpansion\Finalizer\Finalizer.cmd
• GC\Coverage\LargeObjectAlloc2\LargeObjectAlloc2.cmd
• GC\Coverage\LargeObjectAlloc\LargeObjectAlloc.cmd
• GC\API\GC\GetAllocatedBytesForCurrentThread\GetAllocatedBytesForCurrentThread.cmd
• GC\API\GC\GetGCMemoryInfo\GetGCMemoryInfo.cmd
• GC\API\GC\GetTotalAllocatedBytes\GetTotalAllocatedBytes.cmd
• CoreMangLib\system\span\RefStructWithSpan\RefStructWithSpan.cmd
• baseservices\TieredCompilation\TieredVtableMethodTests\TieredVtableMethodTests.cmd
• JIT\Regression\CLR-x86-JIT\V1.1-M1-Beta1\b143840\b143840\b143840.cmd
• JIT\Regression\CLR-x86-JIT\V2.0-Beta2\b425314\b425314\b425314.cmd
• JIT\Regression\JitBlue\GitHub_27924\GitHub_27924\GitHub_27924.cmd
• Loader\classloader\DictionaryExpansion\DictionaryExpansion\DictionaryExpansion.cmd
• profiler\gc\gcbasic\gcbasic.cmd
• JIT\Methodical\VT\port\_dbglcs_gcref\_dbglcs_gcref.cmd
• JIT\Methodical\tailcall_v4\hijacking\hijacking.cmd
• JIT\Methodical\int64\arrays\_il_dbglcs_long\_il_dbglcs_long.cmd
• JIT\Methodical\int64\arrays\_dbglcs_ulong\_dbglcs_ulong.cmd
• JIT\Methodical\int64\arrays\_il_rellcs_ulong\_il_rellcs_ulong.cmd
• JIT\Methodical\int64\arrays\_rellcs_long\_rellcs_long.cmd
• JIT\Methodical\int64\arrays\_dbglcs_long\_dbglcs_long.cmd
• JIT\Methodical\int64\arrays\_speed_dbglcs_ulong\_speed_dbglcs_ulong.cmd
• JIT\Methodical\int64\arrays\_rellcs_ulong\_rellcs_ulong.cmd
• JIT\Methodical\int64\arrays\_speed_rellcs_ulong\_speed_rellcs_ulong.cmd
• JIT\Stress\ABI\stubs_do\stubs_do.cmd
• JIT\Stress\ABI\tailcalls_do\tailcalls_do.cmd
• JIT\Stress\ABI\tailcalls_d\tailcalls_d.cmd
• baseservices\threading\interlocked\compareexchange\CompareExchangeTString\CompareExchangeTString.cmd
• baseservices\threading\regressions\13662\13662-a\13662-a.cmd
• baseservices\threading\regressions\30032\30032\30032.cmd
• baseservices\threading\interlocked\compareexchange\CompareExchangeTClass_1\CompareExchangeTClass_1.cmd
• baseservices\threading\regressions\269336\objmonhelper\objmonhelper.cmd
• baseservices\threading\regressions\beta2\437017\437017.cmd
• Interop\MarshalAPI\IUnknown\IUnknownTestInALC\IUnknownTestInALC.cmd
• tracing\eventpipe\gcdump\gcdump\gcdump.cmd
• Regressions\coreclr\GitHub_45929\test45929\test45929.cmd
• reflection\Tier1Collectible\Tier1Collectible\Tier1Collectible.cmd
• readytorun\tests\mainv1\mainv1.cmd
• readytorun\r2rdump\FrameworkTests\R2RDumpTests\R2RDumpTests.cmd
• readytorun\determinism\crossgen2determinism\crossgen2determinism.cmd
• readytorun\coreroot_determinism\coreroot_determinism\coreroot_determinism.cmd
• Loader\regressions\polyrec\Polyrec\Polyrec.cmd
• Loader\binding\tracing\BinderTracingTest.ResolutionFlow\BinderTracingTest.ResolutionFlow.cmd
• Loader\binding\tracing\BinderTracingTest.Basic\BinderTracingTest.Basic.cmd
• GC\Scenarios\DoublinkList\dlbigleakthd\dlbigleakthd.cmd
• GC\Scenarios\SingLinkList\singlinkstay\singlinkstay.cmd
• GC\Scenarios\SingLinkList\singlinkgen\singlinkgen.cmd
• GC\Scenarios\FinalNStruct\nstructtun\nstructtun.cmd
• GC\Scenarios\DoublinkList\doublinkgen\doublinkgen.cmd
• GC\Scenarios\DoublinkList\dlcollect\dlcollect.cmd
• GC\Scenarios\DoublinkList\doublinkstay\doublinkstay.cmd
• GC\Scenarios\LeakWheel\leakwheel\leakwheel.cmd
• GC\Scenarios\DoublinkList\dlbigleak\dlbigleak.cmd
• GC\Scenarios\ServerModel\servermodel\servermodel.cmd
• GC\Scenarios\ReflectObj\reflectobj\reflectobj.cmd
• GC\Scenarios\DoublinkList\dlstack\dlstack.cmd
• GC\Scenarios\FinalizeTimeout\FinalizeTimeout\FinalizeTimeout.cmd
• GC\Regressions\v2.0-beta2\460373\460373\460373.cmd
• GC\Regressions\v2.0-rtm\494226\494226\494226.cmd
• GC\Regressions\v2.0-beta1\149926\149926\149926.cmd
• GC\Regressions\v2.0-rtm\544701\544701\544701.cmd
• GC\Features\HeapExpansion\plug\plug.cmd
• GC\Features\HeapExpansion\bestfit_1\bestfit_1.cmd
• GC\Features\HeapExpansion\bestfit\bestfit.cmd
• GC\Features\HeapExpansion\pluggaps\pluggaps.cmd
• GC\Features\HeapExpansion\bestfit-finalize\bestfit-finalize.cmd
• GC\Coverage\LargeObjectAlloc2\LargeObjectAlloc2.cmd
• GC\Coverage\LargeObjectAlloc\LargeObjectAlloc.cmd
• GC\API\GC\GetAllocatedBytesForCurrentThread\GetAllocatedBytesForCurrentThread.cmd
• GC\API\GC\GetTotalAllocatedBytes\GetTotalAllocatedBytes.cmd
• CoreMangLib\system\span\RefStructWithSpan\RefStructWithSpan.cmd
• baseservices\TieredCompilation\TieredVtableMethodTests\TieredVtableMethodTests.cmd
• baseservices\compilerservices\dynamicobjectproperties\Dev10_535767\Dev10_535767.cmd
• JIT\Regression\CLR-x86-JIT\V2.0-Beta2\b425314\b425314\b425314.cmd
• JIT\Regression\CLR-x86-JIT\V2.0-Beta2\b426654\b426654\b426654.cmd
• JIT\Regression\JitBlue\GitHub_27924\GitHub_27924\GitHub_27924.cmd
• profiler\gc\gcbasic\gcbasic.cmd
• JIT\Methodical\VT\port\_dbglcs_gcref\_dbglcs_gcref.cmd
• JIT\Methodical\VT\port\_rellcs_gcref\_rellcs_gcref.cmd
• JIT\Methodical\int64\arrays\_dbglcs_ulong\_dbglcs_ulong.cmd
• JIT\Methodical\int64\arrays\_rellcs_ulong\_rellcs_ulong.cmd
• JIT\Methodical\int64\arrays\_dbglcs_long\_dbglcs_long.cmd
• JIT\Methodical\fp\exgen\10w5d_cs_d\10w5d_cs_d.cmd
• JIT\Directed\tailcall\more_tailcalls\more_tailcalls.cmd
• JIT\superpmi\superpmicollect\Bytemark\Bytemark.cmd
• JIT\Performance\CodeQuality\Bytemark\Bytemark\Bytemark.cmd
• JIT\Performance\CodeQuality\BenchmarksGame\k-nucleotide\k-nucleotide-9\k-nucleotide-9.cmd
• JIT\opt\Inline\tests\LotsOfInlines\LotsOfInlines.cmd
• JIT\opt\AssertionPropagation\ArrBoundBinaryOp\ArrBoundBinaryOp.cmd
• baseservices\threading\regressions\269336\objmonhelper\objmonhelper.cmd
• baseservices\threading\interlocked\compareexchange\CompareExchangeTString\CompareExchangeTString.cmd
• baseservices\threading\regressions\13662\13662-simple\13662-simple.cmd
• baseservices\threading\regressions\beta2\437017\437017.cmd
• baseservices\threading\regressions\beta2\437044\437044.cmd
• baseservices\threading\interlocked\compareexchange\CompareExchangeTClass_1\CompareExchangeTClass_1.cmd
• JIT\Generics\Coverage\chaos65204782cs_o\chaos65204782cs_o.cmd
• Interop\COM\NETClients\Primitives\NETClientPrimitivesInALC\NETClientPrimitivesInALC.cmd
• baseservices\threading\generics\threadstart\GThread28\GThread28.cmd
• baseservices\threading\generics\threadstart\GThread03\GThread03.cmd
• baseservices\threading\generics\TimerCallback\thread25\thread25.cmd
• baseservices\threading\generics\TimerCallback\tighttimercallback\tighttimercallback.cmd
• baseservices\threading\generics\threadstart\GThread30\GThread30.cmd

cc: @VSadov @mangod9

[mangod9]

Hi @jkoritzinsky, were these disabled for win7 due to some unrelated issue?

[jkoritzinsky]

We accidentally dropped Windows 7 test coverage when we did repo consolidation. The failing assert was introduced after consolidation, so tests that hit it never ran against Windows 7.

[jkoritzinsky]

I haven't disabled them yet in the PR that adds back the Windows 7 coverage since it seems like a bug that can be hit by any of our tests that use threading, and as a result would result in disabling a swath of tests that are mostly unrelated.

[mangod9]

@VSadov since this was added as part of #47212. Believe validation was done on win7 as part of that change?

[jkoritzinsky]

I do not see the same assert in the 3.1 version of the change, which is the only place we run tests against Windows 7 (and even then only in the official build).

[VSadov]

If we do not have any test coverage in lab runs, I am not sure we tested this with Win7, at least not with Checked build.

This would affect any scenario, not just those that involve threading, since this code is used by GC to suspend runtime.

The assert just checks that InitializeContext returned the right error code. We call the API once with NULL buffer to get the buffer size. This is the documented way to do this. The assert just performs a sanity check.

Do the tests pass in Release? Maybe we just should suppress the assert on Win7?

[jkoritzinsky]

Looking at the 3.1 branch, I do see the same assert and I see the tests passing on Windows 7, so we can probably just remove the assert.

https://github.com/dotnet/coreclr/blob/b58327035e4a1eb056cab86e0a6cc525ca4c3757/src/vm/threadsuspend.cpp#L2466