-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Closed
Labels
area-System.IO.Portshelp wanted[up-for-grabs] Good issue for external contributors[up-for-grabs] Good issue for external contributors
Milestone
Description
When adding a NetCoreAppCurrent configuration to System.IO.Ports, roslyn warns that SerialStream's memory-based ReadAsync and WriteAsync methods aren't overridden. I was unsure if this requires api-approval so I'm filing this issue.
/home/vihofer/runtime/src/libraries/System.IO.Ports/src/System/IO/Ports/SerialStream.cs(13,35): error CA1844: 'SerialStream' overrides array-based 'ReadAsync' but does not override memory-based 'ReadAsync'. Consider overriding memory-based 'ReadAsync' to improve performance. [/home/vihofer/runtime/src/libraries/System.IO.Ports/src/System.IO.Ports.csproj]
/home/vihofer/runtime/src/libraries/System.IO.Ports/src/System/IO/Ports/SerialStream.cs(13,35): error CA1844: 'SerialStream' overrides array-based 'WriteAsync' but does not override memory-based 'WriteAsync'. Consider overriding memory-based 'WriteAsync' to improve performance. [/home/vihofer/runtime/src/libraries/System.IO.Ports/src/System.IO.Ports.csproj]
Metadata
Metadata
Assignees
Labels
area-System.IO.Portshelp wanted[up-for-grabs] Good issue for external contributors[up-for-grabs] Good issue for external contributors