Libraries are missing Unsupported platforms annotations when implementation exists for multiple RIDs

[marek-safar]

Unsupported ref libraries are not correctly annotated or not annotated at all when complex build conditions exist.

I don't know what's the underlying condition but it seems to happen for at least a few in the current build

• System.Security.Cryptography.Algorithms
  • No UnsupportedOSPlatform/SupportedOSPlatform attributes exist in ref assembly even though the assembly is not supported for example on Android
• System.Net.Quic
  • No UnsupportedOSPlatform/SupportedOSPlatform attributes exist in ref assembly even though the assembly is not supported for example on Browser
• System.IO.Ports
  • Only UnsupportedOSPlatform("browser") attribute exists in ref assembly but the assembly is also not supported for example on iOS

This also caused #49201 problem and I checked only a few libraries so not sure how widespread the problem is.

@jeffhandley @buyaa-n

Tagging subscribers to this area: @safern, @ViktorHofer, @Anipik
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Unsupported ref libraries are not correctly annotated or not annotated at all when complex build conditions exist.

I don't know what's the underlying condition but it seems to happen for at least a few in the current build

• System.Security.Cryptography.Algorithms
  • No UnsupportedOSPlatform/SupportedOSPlatform attributes exist in ref assembly even though the assembly is not supported for example on Android
• System.Net.Quic
  • No UnsupportedOSPlatform/SupportedOSPlatform attributes exist in ref assembly even though the assembly is not supported for example on Browser
• System.IO.Ports
  • Only UnsupportedOSPlatform("browser") attribute exists in ref assembly but the assembly is also not supported for example on iOS

This is caused #49201 problem and I checked only a few libraries so not sure how widespread the problem is.

@jeffhandley @buyaa-n

Author:	marek-safar
Assignees:	-
Labels:	area-Infrastructure-libraries, untriaged
Milestone:	-

[buyaa-n]

I think in .NET 5.0, we only annotated Windows only and unsupported on Browser APIs completely. Very few annotations made for other OS in 5.0, we planned that work for 6.0 with #47228 and #44916

[marek-safar]

I think in .NET 5.0

This is .NET6 P1 issue not 5.0.

[buyaa-n]

• System.Security.Cryptography.Algorithms
  • No UnsupportedOSPlatform/SupportedOSPlatform attributes exist in ref assembly even though the assembly is not supported for example on Android

It does have several targets including Android, doesn't have a cross-platform target, for now, i could suggest only add SupportedOSPlatform for each target (Windows, Unix, Android, OSX, iOS, tvOS, Browser), i might have more information after PNSE analysis for targeted builds cc @bartonjs

• System.Net.Quic
  • No UnsupportedOSPlatform/SupportedOSPlatform attributes exist in ref assembly even though the assembly is not supported for example on Browser

Could add assembly level SupportedOSPlaform("windows"), SupportedOSPlaform("Linux"), SupportedOSPlaform("OSX"), SupportedOSPlaform("FreeBSD") attributes

• System.IO.Ports
  • Only UnsupportedOSPlatform("browser") attribute exists in ref assembly but the assembly is also not supported for example on iOS

Could add assembly level SupportedOSPlaform("windows"), SupportedOSPlaform("Linux"), SupportedOSPlaform("OSX"), SupportedOSPlaform("FreeBSD") attributs

[marek-safar]

I'm not following the suggestion. Are you saying we can no longer rely on UnsupportedOSPlatform/SupportedOSPlatform attribute to be automatically generated from implementation libraries and we have to add them manually for each library? How are we going to keep them in-sync?

[buyaa-n]

It will not generated in the Cross-platform target for example for Quic $(NetCoreAppCurrent)-windows;$(NetCoreAppCurrent)-Linux;$(NetCoreAppCurrent)-OSX;$(NetCoreAppCurrent)-FreeBSD; targets will have their own Supported attributes but there will be no attribute for $(NetCoreAppCurrent) build which is i guess the official one, the ref assembly of Quic only have $(NetCoreAppCurrent) so it also will not have any attribute