Fix layering of C# formatting options #79083
Conversation
| #else | ||
| public enum BinaryOperatorSpacingOptions | ||
| #endif | ||
| internal enum BinaryOperatorSpacingOptionsInternal |
There was a problem hiding this comment.
this was causing no end of pain.
src/Workspaces/CSharp/Portable/Formatting/CSharpFormattingOptions.cs
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| public enum LabelPositionOptions |
There was a problem hiding this comment.
thse are not new apis. they just moved from the shared location her.e we don't want it in teh shared location as that adds public types to multiple assemblies, which is bad (esp. for code that then references both assemblies.
| #else | ||
| public enum LabelPositionOptions | ||
| #endif | ||
| internal enum LabelPositionOptionsInternal |
There was a problem hiding this comment.
these are now internal and renamed (so no conflicts anymore). all shared code now uses the internal option.
...rkspaces/SharedUtilitiesAndExtensions/Compiler/Core/Options/EditorConfigValueSerializer`1.cs
Show resolved
Hide resolved
|
@JoeRobich @tmat ptal. |
| where TToEnum : struct, Enum | ||
| { | ||
| // Ensure that this is only called for enums that are actually compatible with each other. | ||
| Contract.ThrowIfTrue(typeof(TFromEnum).GetEnumUnderlyingType() != typeof(int)); |
There was a problem hiding this comment.
Shouldn't this just be typeof(TFromEnum).GetEnumUnderlyingType() != typeof(TToEnum).GetEnumUnderlyingType()?
There was a problem hiding this comment.
this has changed. i previously took a dependency on int in teh impl code. now i have a TEnumUnderlyingType that i can use instead.
And i do confirm that everything is cromulent between all 3 type parameters.
This was done. PTAL @tmat |
| where TToEnum : struct | ||
| where TUnderlyingEnumType : struct | ||
| { | ||
| return Unsafe.As<TUnderlyingEnumType, TToEnum>(ref Unsafe.As<TFromEnum, TUnderlyingEnumType>(ref value)); |
There was a problem hiding this comment.
witness, the power of .net. note that this should get fully elided to nothing in the jit :)
src/Workspaces/CSharp/Portable/Formatting/CSharpFormattingOptions.cs
Outdated
Show resolved
Hide resolved
4 participants
No description provided.