Skip to content

Conversation

@CyrusNajmabadi
Copy link
Member

Fixes #78002

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner June 19, 2025 20:05
@CyrusNajmabadi CyrusNajmabadi requested a review from akhera99 June 19, 2025 20:15
CyrusNajmabadi and others added 2 commits June 19, 2025 13:26
…sform_TopLevelStatements.cs

Co-authored-by: DoctorKrolic <[email protected]>
…sform_TopLevelStatements.cs

Co-authored-by: DoctorKrolic <[email protected]>
@CyrusNajmabadi
Copy link
Member Author

@akhera99 @AbhitejJohn ptal.

using System;
#if true
Console.WriteLine("true");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it feels a bit weird for the statements to be differently tabbed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Though it matches our philosophy of not touching pp contents as we do not actually know what they represent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Convert to top-level statements" does not correctly handle code excluded by conditional preprocessor directive

5 participants