Fix layering of modifier api. #79022
Conversation
| using DeclarationModifiers = Microsoft.CodeAnalysis.Internal.Editing.DeclarationModifiers; | ||
| #else | ||
| using DeclarationModifiers = Microsoft.CodeAnalysis.Editing.DeclarationModifiers; | ||
| #endif |
There was a problem hiding this comment.
this was teh core thing i wanted to get rid of. we have DeclarationModifiers as a public API in teh workspace. We then also cloned it into an internal namespace, both to get access to internal parts of it and to pull it down to our 'analyzer/compiler' layer. That's awwful.
I've separated this out so there's a trivial enum now at hte analyzer/compiler layer. ANd only workspace/fixer/refactoring layer types access the true DeclarationModifiers type.
| File = 1 << 17, | ||
| Fixed = 1 << 18, | ||
| #pragma warning restore format | ||
| } |
There was a problem hiding this comment.
this is what was extracted out to the lower layer.
| #if WORKSPACE | ||
| return new DeclarationModifiers(modifiers); | ||
| #else | ||
| return Unsafe.As<Modifiers, DeclarationModifiers>(ref modifiers); |
There was a problem hiding this comment.
ugly, but simple. if we are ever worried about this, we can always write the full logic that checks each flag and creates teh final DeclarationModifiers from it.
There was a problem hiding this comment.
And this works because DeclarationModifiers is a struct with a single field that is of type Modifiers?
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/CompilerExtensions.projitems
Outdated
Show resolved
Hide resolved
src/Workspaces/SharedUtilitiesAndExtensions/Workspace/Core/WorkspaceExtensions.projitems
Outdated
Show resolved
Hide resolved
dotnet-policy-service
bot
added
the
Needs API Review
4 participants
No description provided.