Breaking out refactoring helpers into core api vs service #79012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tmat ptal. |
CyrusNajmabadi
commented
Jun 17, 2025
| protected override IHeaderFacts HeaderFacts => CSharpHeaderFacts.Instance; | ||
| protected override ISyntaxFacts SyntaxFacts => CSharpSyntaxFacts.Instance; | ||
|
|
||
| public override bool IsBetweenTypeMembers(SourceText sourceText, SyntaxNode root, int position, [NotNullWhen(true)] out SyntaxNode? typeDeclaration) |
There was a problem hiding this comment.
all teh logic below here is a move.
CyrusNajmabadi
commented
Jun 17, 2025
|
|
||
| public abstract bool IsBetweenTypeMembers(SourceText sourceText, SyntaxNode root, int position, [NotNullWhen(true)] out SyntaxNode? typeDeclaration); | ||
|
|
||
| private static void AddNode<TSyntaxNode>(bool allowEmptyNodes, ref TemporaryArray<TSyntaxNode> result, TSyntaxNode node) where TSyntaxNode : SyntaxNode |
There was a problem hiding this comment.
all the logic below here is a move.
tmat
reviewed
Jun 17, 2025
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/CSharpCompilerExtensions.projitems
Outdated
Show resolved
Hide resolved
tmat
reviewed
Jun 17, 2025
| <ItemGroup Condition="'$(DefaultLanguageSourceExtension)' != '' AND '$(BuildingInsideVisualStudio)' != 'true'"> | ||
| <ExpectedCompile Include="$(MSBuildThisFileDirectory)**\*$(DefaultLanguageSourceExtension)" /> | ||
| </ItemGroup> | ||
| <ItemGroup> |
tmat
reviewed
Jun 17, 2025
...ilitiesAndExtensions/Compiler/CSharp/Services/RefactoringHelpers/CSharpRefactoringHelpers.cs
Show resolved
Hide resolved
tmat
reviewed
Jun 17, 2025
| /// </summary> | ||
| void AddRelevantNodes<TSyntaxNode>( | ||
| ParsedDocument document, TextSpan selection, bool allowEmptyNodes, int maxCount, ref TemporaryArray<TSyntaxNode> result, CancellationToken cancellationToken) where TSyntaxNode : SyntaxNode; | ||
| internal static class IRefactoringHelpersServiceExtensions |
There was a problem hiding this comment.
this keeps source compat, making it less painful to move over :)
CyrusNajmabadi
commented
Jun 17, 2025
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/CSharpCompilerExtensions.projitems
Outdated
Show resolved
Hide resolved
…harpCompilerExtensions.projitems
…i/roslyn into refactoringHelpers
CyrusNajmabadi
commented
Jun 17, 2025
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/CSharpCompilerExtensions.projitems
Outdated
Show resolved
Hide resolved
…harpCompilerExtensions.projitems
CyrusNajmabadi
commented
Jun 17, 2025
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/CompilerExtensions.projitems
Outdated
Show resolved
Hide resolved
…ilerExtensions.projitems
CyrusNajmabadi
commented
Jun 17, 2025
...es/SharedUtilitiesAndExtensions/Compiler/VisualBasic/VisualBasicCompilerExtensions.projitems
Outdated
Show resolved
Hide resolved
…ic/VisualBasicCompilerExtensions.projitems
tmat
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.