Fix DeclarationKind layering #79009
Merged
Fix DeclarationKind layering #79009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
VSCode
Needs API Review
CyrusNajmabadi
commented
Jun 17, 2025
| case SyntaxKind.VariableDeclarator: | ||
| var declarationKind = GetDeclarationKind(declaration); | ||
| return declarationKind is DeclarationKind.Field or DeclarationKind.Event; | ||
| return declaration.Parent is VariableDeclarationSyntax { Parent: BaseFieldDeclarationSyntax }; |
Member
Author
There was a problem hiding this comment.
we were pulling in an entire helper method, which had dependencies on a workspace enum, into this non-workspace-layer helper.
Untangled that, so that we don't need to try to make this enum available in two layers (esp. as it is already public)..
CyrusNajmabadi
commented
Jun 17, 2025
| public override DeclarationKind GetDeclarationKind(SyntaxNode declaration) | ||
| => CSharpAccessibilityFacts.GetDeclarationKind(declaration); | ||
| { | ||
| switch (declaration.Kind()) |
Member
Author
There was a problem hiding this comment.
move. no logic touched at all.
CyrusNajmabadi
commented
Jun 17, 2025
| <InternalsVisibleTo Include="Microsoft.CodeAnalysis.VisualBasic.CodeStyle.UnitTests" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Compile Include="..\..\..\Workspaces\Core\Portable\Editing\DeclarationKind.cs" Link="Editing\DeclarationKind.cs" /> |
Member
Author
There was a problem hiding this comment.
and there was much rejoicing.
tmat
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.