Second attempt at updating versions #78796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tmat @jasonmalinowski ptal. |
jasonmalinowski
approved these changes
Jun 2, 2025
CyrusNajmabadi
force-pushed
the
updateVersions2
branch
from
b6975ce to
df2047f
Compare
CyrusNajmabadi
force-pushed
the
updateVersions2
branch
2 times, most recently
from
b6975ce to
0db1511
Compare
|
/azp run |
The editor's SetOptionValue now asserts it must be on the UI thread.
…06733 This can be reverted cleanly once the underlying bug is fixed.
Since it's just one test and it's a trivial editor fix, no reason to fight with trying to create a mock.
| } | ||
|
|
||
| [WpfFact] | ||
| [WpfFact(Skip = "https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2506733")] |
There was a problem hiding this comment.
This one really expects IGlyphService, easiest to just skip it and revert this.
jasonmalinowski
approved these changes
Jun 13, 2025
jaredpar
approved these changes
Jun 13, 2025
phil-allen-msft
approved these changes
Jun 13, 2025
JoeRobich
approved these changes
Jun 16, 2025
Otherwise this creates a memory leak.
Otherwise this logger might get set between tests and that can cause memory leaks since some code will call SetLogger to add a logger, and keep adding more and more loggers.
|
Per @jaredpar the failure in the Test_Linux_Debug queue is a known timeout issue in infrastructure. |
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.