Implement the editor's new 'speculative edit' api to allow copilot suggestions to be classified accurately with Roslyn.

[CyrusNajmabadi]

No description provided.

[CyrusNajmabadi]

same here. this is what AbstractPreviewFactoryService does to fork and get the new roslyn solution.

[jasonmalinowski]

This is quite fishy since we're doing the OpenDocument call which will probably do the same thing...? Or I guess this is forking all linked copies?

[CyrusNajmabadi]

yes. WithDocumentText just sets the doc text for everything. .OpenDocument ensures all of the following runs:

            onAfterUpdate: static (oldSolution, newSolution, data) =>
            {
                var (@this, documentId, textContainer, isCurrentContext, requireDocumentPresentAndClosed) = data;

                @this.AddToOpenDocumentMap(documentId);
                @this.SignupForTextChanges(documentId, textContainer, isCurrentContext, (w, id, text, mode) => w.OnDocumentTextChanged(id, text, mode));

                var newDoc = newSolution.GetRequiredDocument(documentId);
                @this.OnDocumentTextChanged(newDoc);

                // Fire and forget that the workspace is changing.
                @this.RaiseWorkspaceChangedEventAsync(WorkspaceChangeKind.DocumentChanged, oldSolution, newSolution, documentId: documentId);

                // We fire 2 events on source document opened.
                @this.RaiseDocumentOpenedEventAsync(newDoc);
                @this.RaiseTextDocumentOpenedEventAsync(newDoc);
            });

Now, how important it is for that to run is unclear to me. However, this is what the lightbulb does for its preview buffers, so i figured i would eliminate chances for strangeness and keep in sync.

[jasonmalinowski]

Maybe file a bug to investigate, but if this is what PreviewWorkspace is doing then we can fix them all up at once.

[jasonmalinowski]

Not sure if we have to mark this as private dependency or something. It doesn't appear we upload this package to NuGet (and haven't in quite some time), but check if the editor team has a special requirement here.

[CyrusNajmabadi]

@jasonmalinowski is this a blocking concern on your part? or ca this be merged in and this poitn be resolved later?

[kayle]

text.internal is not part of the vssdk and we don't publish it to nuget

[jasonmalinowski]

We specifically put a method on the base type to do the cloning so we didn't have to reinvent this bit -- was that not usable?

[CyrusNajmabadi]

That guy doesn't ensure that we get an ITextDocument with a proper .cs path.

[CyrusNajmabadi]

I wouldn't expect us to have to do this in this case since I don't think we're expecting an LSP hookup to this? This might actually cause problems?

If we don't have LSP hookup, then things like classification through LSP would not work.

[CyrusNajmabadi]

@jasonmalinowski anything remaining that needs to change in this PR for you?

[jasonmalinowski]

This comment seems backwards from the code -- the comment says we're grabbing the snapshot from the buffer, but the code is grabbing the buffer from the snapshot.

[jasonmalinowski]

Why "beforeEdits" in the name -- it's representing after the edits, right?

[jasonmalinowski]

Maybe file a bug to investigate, but if this is what PreviewWorkspace is doing then we can fix them all up at once.

[jasonmalinowski]

This could just be clonedSnapshotBeforeEdits.AsText() rather than jumping to the container and back.

[CyrusNajmabadi]

Will fix all feedback in followup.