Unify roslyn analyzers on single version #78381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes our RoslynAnalyzers layer to unify on a single version of the Microsoft.CodeAnalysis APIs
ghost
added
Area-Infrastructure
untriaged
jaredpar
commented
Apr 29, 2025
| <DefineConstants>$(DefineConstants),CODEANALYSIS_V3_7_OR_BETTER</DefineConstants> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition="'$(MicrosoftCodeAnalysisVersion)' == '' OR $([MSBuild]::VersionNotEquals('$(MicrosoftCodeAnalysisVersion)','1.2.1'))"> | ||
| <PropertyGroup Condition="'$(MicrosoftCodeAnalysisVersionForAnalyzers)' == '' OR $([MSBuild]::VersionNotEquals('$(MicrosoftCodeAnalysisVersion)','1.2.1'))"> |
There was a problem hiding this comment.
Now that the min version is 4.0.1 I'm not sure we need this anymore. Could mean we could simplify a bit here.
sharwell
reviewed
Apr 30, 2025
|
|
||
| <DefineConstants Condition="'$(LEGACY_CODE_METRICS_MODE)' == 'true'">$(DefineConstants),LEGACY_CODE_METRICS_MODE</DefineConstants> | ||
|
|
||
| <MicrosoftCodeAnalysisVersionForAnalyzer>4.0.1</MicrosoftCodeAnalysisVersionForAnalyzer> |
There was a problem hiding this comment.
I wouldn't hate if this was Analyzers instead of Analyzer, but it's basically a change everywhere so certainly not blocking on it.
sharwell
reviewed
Apr 30, 2025
|
|
||
| <!-- RS0026: Avoid public API overloads with differences in optional parameters --> | ||
| <NoWarn>$(NoWarn);RS0026</NoWarn> | ||
| <MicrosoftCodeAnalysisVersion Condition="'$(MicrosoftCodeAnalysisVersion)' == ''">$(MicrosoftCodeAnalysisVersionForCodeAnalysisAnalyzers)</MicrosoftCodeAnalysisVersion> |
There was a problem hiding this comment.
Is $(MicrosoftCodeAnalysisVersionForCodeAnalysisAnalyzers) defined anywhere?
sharwell
reviewed
Apr 30, 2025
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" VersionOverride="$(MicrosoftCodeAnalysisVersionForAnalyzer)" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.VisualBasic" VersionOverride="$(MicrosoftCodeAnalysisVersionForAnalyzer)" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.VisualBasic.Workspaces" VersionOverride="$(MicrosoftCodeAnalysisVersionForAnalyzer)" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.Workspaces.Common" VersionOverride="$(MicrosoftCodeAnalysisVersionForAnalyzer)" /> |
There was a problem hiding this comment.
This block should be using MicrosoftCodeAnalysisVersionForAnalyzerTests
sharwell
reviewed
Apr 30, 2025
|
|
||
| <!-- Avoid ID conflicts with the package project. --> | ||
| <PackageId>*$(MSBuildProjectFile)*</PackageId> | ||
| <MicrosoftCodeAnalysisVersion Condition="'$(MicrosoftCodeAnalysisVersion)' == ''">$(MicrosoftCodeAnalysisVersionForResxSourceGenerators)</MicrosoftCodeAnalysisVersion> |
There was a problem hiding this comment.
📝 It would be good to lock this analyzer to an older version, because it doesn't need many APIs, doesn't look at source code, and we want it to work in a wide range of projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes our RoslynAnalyzers layer to unify on a single version of the Microsoft.CodeAnalysis APIs