Skip to content

Support IsActiveDocument in RoslynCodeSearchResult #77311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 17, 2025
Merged

Support IsActiveDocument in RoslynCodeSearchResult #77311

merged 14 commits into from
Jun 17, 2025

Conversation

@sandyarmstrong
Copy link
Member

@sandyarmstrong sandyarmstrong commented Feb 21, 2025 •
edited
Loading

Cyrus fixed #77051, opening the door for All-in-one Search's "Current Document" scope to include results from base types and partial types (not literally the current document).

To avoid confusing users, it was suggested that we should prioritize results from the literal current document. Since providers are already checking this, we decided to add CodeSearchResult.IsActiveDocument to the existing API so that providers can set the flag for AIOS to check during sorting.

Now results with that flag set will rise to the top when the user has the "Current Document" scope set.

@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 21, 2025
CyrusNajmabadi
CyrusNajmabadi reviewed Feb 21, 2025
View reviewed changes
@sandyarmstrong
Copy link
Member Author

This won't build until a corresponding change lands on the VS side. I just wanted to put drafts up on each side to get feedback on the approach.

@sandyarmstrong sandyarmstrong force-pushed the dev/sandy/aios-active-document branch from d2cc2b8 to 33adb91 Compare March 10, 2025 16:54
@sandyarmstrong sandyarmstrong changed the base branch from main to main-vs-deps March 10, 2025 16:54
@sandyarmstrong sandyarmstrong marked this pull request as ready for review March 10, 2025 16:54
@sandyarmstrong sandyarmstrong requested review from a team as code owners March 10, 2025 16:54
@sandyarmstrong
Copy link
Member Author

@tmat locally, this build is failing during SemanticSearch's GenerateFilteredReferenceAssembliesTask, with this error https://gist.github.com/sandyarmstrong/572c99b6ac33f476e4881c5c1861a153. I bumped some packages, but not immutable collections (those are already bumped to 9.0.0 in main-vs-deps). Any thoughts on this?

@sandyarmstrong sandyarmstrong force-pushed the dev/sandy/aios-active-document branch from 33adb91 to cc4b644 Compare March 13, 2025 16:08
@jasonmalinowski jasonmalinowski changed the base branch from main-vs-deps to main March 27, 2025 20:16
@CyrusNajmabadi
Copy link
Member

@sandyarmstrong what version of the platform apis do we need to update to to get this new api?

@sandyarmstrong
Copy link
Member Author

sandyarmstrong commented Jun 12, 2025 •
edited
Loading

@sandyarmstrong what version of the platform apis do we need to update to to get this new api?

17.14 stable packages. At the time of this PR, I was trying to integrate MS.VS.Search 17.14.39359 but it required other package bumps that led to a cascade of build failures.

@CyrusNajmabadi CyrusNajmabadi enabled auto-merge June 12, 2025 18:55
@CyrusNajmabadi CyrusNajmabadi disabled auto-merge June 12, 2025 18:56
@CyrusNajmabadi CyrusNajmabadi enabled auto-merge June 12, 2025 19:04
@CyrusNajmabadi
Copy link
Member

@sandyarmstrong made the changes i think are relevant.

@CyrusNajmabadi
Copy link
Member

@jasonmalinowski i'm not sure what to do about the build breaks in CI. This all builds locally for me (on command line and in VS) :(

CyrusNajmabadi and others added 7 commits June 16, 2025 18:12
@CyrusNajmabadi
revert
85a9e32
@CyrusNajmabadi
fix
ecfe20d
@jasonmalinowski @CyrusNajmabadi
Remove now unused Progression references and related hacks
b0615e7
@jasonmalinowski @CyrusNajmabadi
Remove more unneeded references
5c10978
@jasonmalinowski @CyrusNajmabadi
Remove duplicate code that's fetching the global namespace
47b3b66 
This existed back from when the input to the function was a namespace,
but that's not the case anymore.
@jasonmalinowski @CyrusNajmabadi
Fix locating startup objects
19bbaba 
CPS passes us an INamespaceSymbol that is the global namespace symbol;
it doesn't have a containing assembly. It does have a containing
Compilation though, which is what we actually need.

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2506795
Fixes #78697
@jasonmalinowski @CyrusNajmabadi
Expose as a new entrypoint a Compilation-accepting version
d3589f0 
I'm not sure why this ever took an INamespaceSymbol in the first place,
but we either have code working around it, or having an (old) comment
saying the code was wrong.
@CyrusNajmabadi CyrusNajmabadi force-pushed the dev/sandy/aios-active-document branch from 48de68b to d3589f0 Compare June 17, 2025 01:13
@CyrusNajmabadi CyrusNajmabadi changed the base branch from main to main-vs-deps June 17, 2025 01:13
@CyrusNajmabadi CyrusNajmabadi merged commit 163dfa8 into main-vs-deps Jun 17, 2025
27 of 28 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jun 17, 2025
@CyrusNajmabadi CyrusNajmabadi deleted the dev/sandy/aios-active-document branch June 17, 2025 06:36
This was referenced Jun 20, 2025
Closed
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Jun 29, 2025
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees

No one assigned

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Milestone

18.0 P1

Development

Successfully merging this pull request may close these issues.

NavTo: Enhance "Current Document" scope with results from base types and partial types

5 participants

@sandyarmstrong @CyrusNajmabadi @RikkiGibson @jasonmalinowski