Make razor generator always run: #77304
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chsienki
commented
Feb 20, 2025
chsienki
commented
- Introduce a new creation policy that runs only 'required' generators
- Add a generator filter that hard codes razor to run in the required policy mode
ghost
added
Area-IDE
untriaged
|
|
||
| /// <summary> | ||
| /// Source generators should not run. Whatever results were previously computed should be reused. | ||
| /// </summary> |
There was a problem hiding this comment.
why not just do 'DoNotCreate_ExceptRequired' (for the value below). i'm not sure we want/need 3 values. just that the second value shoudl always run razor(if you're saying it is always necessary for razor to run).
There was a problem hiding this comment.
So that's what I was originally going to do. But when running in a debugger it seemed like the DoNotCreate path was always run after the create path, even in Automatic mode. That suggested to me that it was still going to be required? In theory we could re-run razor and it should just be a no-op?
I do not know/understand the intricacies of when this code gets called to know well enough if that would still be acceptable :)
- Introduce a new creation policy that runs only 'required' generators - Add a generator filter that hard codes razor to run in the required policy mode
chsienki
force-pushed
the
razor_gen_always_run
branch
2 times, most recently
from
3f74b01 to
f302e47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.