Skip to content

Move GetOrCreateTypeByMetadataName to compilation start #6332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 20, 2022
Merged

Move GetOrCreateTypeByMetadataName to compilation start #6332

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9d44a3
Move `GetOrCreateTypeByMetadataName` to compilation start
Youssef1313 Dec 12, 2022
5ffc2c7
Fix build
Youssef1313 Dec 12, 2022
3a821da
Update AvoidZeroLengthArrayAllocations.cs
Youssef1313 Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/AvoidZeroLengthArrayAllocations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,26 +50,27 @@ public sealed override void Initialize(AnalysisContext context)

// When compilation begins, check whether Array.Empty<T> is available.
// Only if it is, register the syntax node action provided by the derived implementations.
context.RegisterCompilationStartAction(ctx =>
context.RegisterCompilationStartAction(context =>
{
INamedTypeSymbol typeSymbol = ctx.Compilation.GetSpecialType(SpecialType.System_Array);
INamedTypeSymbol typeSymbol = context.Compilation.GetSpecialType(SpecialType.System_Array);
if (typeSymbol.DeclaredAccessibility == Accessibility.Public)
{
if (typeSymbol.GetMembers(ArrayEmptyMethodName).FirstOrDefault() is IMethodSymbol methodSymbol && methodSymbol.DeclaredAccessibility == Accessibility.Public &&
methodSymbol.IsStatic && methodSymbol.Arity == 1 && methodSymbol.Parameters.IsEmpty)
{
ctx.RegisterOperationAction(c => AnalyzeOperation(c, methodSymbol), OperationKind.ArrayCreation);
var linqExpressionType = context.Compilation.GetOrCreateTypeByMetadataName(WellKnownTypeNames.SystemLinqExpressionsExpression1);
context.RegisterOperationAction(c => AnalyzeOperation(c, methodSymbol, linqExpressionType), OperationKind.ArrayCreation);
}
}
});
}

private void AnalyzeOperation(OperationAnalysisContext context, IMethodSymbol arrayEmptyMethodSymbol)
private void AnalyzeOperation(OperationAnalysisContext context, IMethodSymbol arrayEmptyMethodSymbol, INamedTypeSymbol? linqExpressionType)
{
AnalyzeOperation(context, arrayEmptyMethodSymbol, IsAttributeSyntax);
AnalyzeOperation(context, arrayEmptyMethodSymbol, linqExpressionType, IsAttributeSyntax);
}

private static void AnalyzeOperation(OperationAnalysisContext context, IMethodSymbol arrayEmptyMethodSymbol, Func<SyntaxNode, bool> isAttributeSyntax)
private static void AnalyzeOperation(OperationAnalysisContext context, IMethodSymbol arrayEmptyMethodSymbol, INamedTypeSymbol? linqExpressionType, Func<SyntaxNode, bool> isAttributeSyntax)
{
IArrayCreationOperation arrayCreationExpression = (IArrayCreationOperation)context.Operation;

Expand All @@ -80,7 +81,6 @@ private static void AnalyzeOperation(OperationAnalysisContext context, IMethodSy
return;
}

var linqExpressionType = context.Compilation.GetOrCreateTypeByMetadataName(WellKnownTypeNames.SystemLinqExpressionsExpression1);
if (arrayCreationExpression.IsWithinExpressionTree(linqExpressionType))
{
return;
Expand Down