Skip to content

Conversation

@MattKotsenas
Copy link
Member

Fixes #46

Addresses the difference in behavior between the .NET 9 SDK's version of SourceLink and our own branch logic. Doing so has two implications:

  1. We no longer attempt to shorten git refs like refs/heads/ or refs/tags/
  2. We prefer the tag over the branch over the PR ID (old logic was PR ID, tag, branch)

For code reviewers I suggest reviewing each commit separately, as the first moves the test data and covers all the combinations of values, and the second is the logic and test result change

@MattKotsenas MattKotsenas requested a review from a team as a code owner August 30, 2024 23:10
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the useful per-commit breakout! This LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RepositoryBranch logic conflicts with .NET 9 SDK

3 participants