Skip to content

Conversation

@MattKotsenas
Copy link
Member

@MattKotsenas MattKotsenas commented Jun 29, 2024

Fixes #42

Switch to the newer dotnet/sign CLI tool. As part of the switch I refactored the YAML file slightly:

  1. Add a minimum SDK version in global.json. This helps prevent "works on my machine" issues by ensuring that CI is running a reasonable SDK version. I'm open to suggestions on the rollforward strategy; currently being as permissive as possible
  2. Switch the YAML from using a deployment to a regular job; deployments aren't used very commonly and behave a bit differently (i.e. don't clone, automatically download all artifacts, etc.) so using a regular job to be "less magical"
  3. Rather than install the sign tool in the CI pipeline, I add it as a dotnet tool; this makes it easier to discover / upgrade versions since that tool is stored with the others

@MattKotsenas MattKotsenas force-pushed the feature/sign-tool branch 6 times, most recently from 95bb714 to 37d6150 Compare July 2, 2024 02:40
@MattKotsenas
Copy link
Member Author

@MattKotsenas MattKotsenas requested a review from baronfel July 2, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to dotnet/sign

2 participants