Skip to content

Remove support for .NET Core 2.1 and netstandard1.0. bump .net to 4.8 #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp2.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
<Optimize>true</Optimize>
<Configurations>Current Sources;Ix.net 3.1.1;Ix.net 3.2</Configurations>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@

namespace Benchmarks.System.Interactive
{

#if !NET6_0_OR_GREATER

[MemoryDiagnoser]
public class MinMaxBenchmark
{
Expand Down Expand Up @@ -43,4 +46,5 @@ public void MaxBy()
Volatile.Write(ref _listStore, Enumerable.Range(1, N).MaxBy(v => -v, _comparer));
}
}
#endif
}
5 changes: 4 additions & 1 deletion Ix.NET/Source/Benchmarks.System.Interactive/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,11 @@ internal static void Main()
typeof(BufferCountBenchmark),
typeof(IgnoreElementsBenchmark),
typeof(DeferBenchmark),
typeof(RetryBenchmark),
typeof(RetryBenchmark)
#if !NET6_0_OR_GREATER
,
typeof(MinMaxBenchmark)
#endif
});

switcher.Run();
Expand Down
22 changes: 0 additions & 22 deletions Ix.NET/Source/Directory.Build.targets
Original file line number Diff line number Diff line change
@@ -1,31 +1,9 @@
<Project>

<!-- This props all need to be set in targets as they depend on the values set earlier -->
<PropertyGroup Condition="'$(TargetFramework)' == 'netstandard1.0'">
<DefineConstants>$(DefineConstants);NO_ARRAY_EMPTY;NO_CODE_COVERAGE_ATTRIBUTE</DefineConstants>
</PropertyGroup>
<PropertyGroup Condition="'$(TargetFramework)' == 'netstandard1.4'">
<DefineConstants>$(DefineConstants);NO_CODE_COVERAGE_ATTRIBUTE</DefineConstants>
</PropertyGroup>
<PropertyGroup Condition="'$(TargetFramework)' == 'net45'">
<DefineConstants>$(DefineConstants);NO_ARRAY_EMPTY;NO_TASK_FROMEXCEPTION</DefineConstants>
</PropertyGroup>
<PropertyGroup Condition="'$(TargetFramework)' == 'netcoreapp3.1' or '$(TargetFramework)' == 'netstandard2.1' or '$(TargetFramework)' == 'netstandard2.0'">
<DefineConstants>$(DefineConstants);HAS_VALUETUPLE</DefineConstants>
</PropertyGroup>

<PropertyGroup>
<Product>$(AssemblyName) ($(TargetFramework))</Product>
</PropertyGroup>

<!-- Remove once coverlet supports this built-in -->
<Target Name="CoverletGetPathMap"
DependsOnTargets="InitializeSourceRootMappedPaths"
Returns="@(_LocalTopLevelSourceRoot)"
Condition="'$(DeterministicSourcePaths)' == 'true'">
<ItemGroup>
<_LocalTopLevelSourceRoot Include="@(SourceRoot)" Condition="'%(SourceRoot.NestedRoot)' == ''"/>
</ItemGroup>
</Target>

</Project>
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netcoreapp2.1;net461;netcoreapp3.1;net6.0</TargetFrameworks>
<TargetFrameworks>net48;net6.0;netcoreapp3.1</TargetFrameworks>
<NoWarn>$(NoWarn);CS0618</NoWarn>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<Description>Interactive Extensions Async Providers Library used to build query providers and express queries over async enumerable sequences.</Description>
<AssemblyTitle>Interactive Extensions - Async Providers Library</AssemblyTitle>
<TargetFrameworks>net461;netstandard2.0;netstandard2.1;netcoreapp3.1</TargetFrameworks>
<TargetFrameworks>net48;netstandard2.0;netstandard2.1;net6.0</TargetFrameworks>
<PackageTags>Ix;Interactive;Extensions;Enumerable;Asynchronous</PackageTags>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netcoreapp2.1;net461;netcoreapp3.1;net6.0</TargetFrameworks>
<TargetFrameworks>net48;net6.0;netcoreapp3.1</TargetFrameworks>
<NoWarn>$(NoWarn);CS0618;CS8603;CS8625</NoWarn>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<Description>Interactive Extensions Async Library used to express queries over asynchronous enumerable sequences.</Description>
<AssemblyTitle>Interactive Extensions - Async Library</AssemblyTitle>
<TargetFrameworks>net461;netstandard2.0;netstandard2.1;netcoreapp3.1</TargetFrameworks>
<TargetFrameworks>net48;netstandard2.0;netstandard2.1;net6.0</TargetFrameworks>
<PackageTags>Ix;Interactive;Extensions;Enumerable;Asynchronous</PackageTags>
</PropertyGroup>

Expand Down
55 changes: 0 additions & 55 deletions Ix.NET/Source/System.Interactive.Providers/Reflection.cs

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,10 @@
<PropertyGroup>
<Description>Interactive Extensions Providers Library used to build query providers and express queries over enumerable sequences.</Description>
<AssemblyTitle>Interactive Extensions - Providers Library</AssemblyTitle>
<TargetFrameworks>net45;netstandard1.0;netstandard2.0</TargetFrameworks>
<TargetFrameworks>net48;netstandard2.0;net6.0</TargetFrameworks>
<PackageTags>Ix;Interactive;Extensions;Enumerable</PackageTags>
</PropertyGroup>

<PropertyGroup Condition="'$(TargetFramework)' == 'netstandard1.0'">
<DefineConstants>$(DefineConstants);CRIPPLED_REFLECTION</DefineConstants>
</PropertyGroup>

<ItemGroup>
<EmbeddedResource Include="Properties\System.Interactive.Providers.rd.xml" />
</ItemGroup>
Expand All @@ -20,8 +16,4 @@
<ReferenceAssemblyProjectReference Include="..\refs\System.Interactive.Providers.Ref\System.Interactive.Providers.Ref.csproj" ReferenceOutputAssembly="false" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'netstandard1.0'">
<PackageReference Include="System.Linq.Queryable" Version="4.3.0" />
</ItemGroup>

</Project>
Loading