Skip to content

Update to 6.0 SDK and exclude min/max/minby/maxby from 6.0 refs #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Ix.NET/Source/ApiCompare/ApiCompare.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp2.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion Ix.NET/Source/FasterLinq/FasterLinq.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp2.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
</PropertyGroup>

</Project>
2 changes: 1 addition & 1 deletion Ix.NET/Source/Playground/Playground.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp2.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netcoreapp2.1;net461;netcoreapp3.1</TargetFrameworks>
<TargetFrameworks>netcoreapp2.1;net461;netcoreapp3.1;net6.0</TargetFrameworks>
<NoWarn>$(NoWarn);CS0618</NoWarn>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netcoreapp2.1;net461;netcoreapp3.1</TargetFrameworks>
<TargetFrameworks>netcoreapp2.1;net461;netcoreapp3.1;net6.0</TargetFrameworks>
<NoWarn>$(NoWarn);CS0618;CS8603;CS8625</NoWarn>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

<ItemGroup>
<ProjectReference Include="..\System.Interactive\System.Interactive.csproj" />
<ReferenceAssemblyProjectReference Include="..\refs\System.Interactive.Providers.Ref\System.Interactive.Providers.Ref.csproj" />
<ReferenceAssemblyProjectReference Include="..\refs\System.Interactive.Providers.Ref\System.Interactive.Providers.Ref.csproj" ReferenceOutputAssembly="false" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'netstandard1.0'">
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netcoreapp2.1;net461</TargetFrameworks>
<TargetFrameworks>netcoreapp2.1;net461;net6.0</TargetFrameworks>
<NoWarn>$(NoWarn);CS0618;CS8603;CS8625</NoWarn>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ namespace Tests
{
public class Max : Tests
{
#if !NET6_0_OR_GREATER
[Fact]
public void Max_Arguments()
{
Expand All @@ -31,5 +32,6 @@ public int Compare(int x, int y)
return Comparer<int>.Default.Compare(x % 7, y % 7);
}
}
#endif
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ namespace Tests
{
public class MaxBy : Tests
{
#if !NET6_0_OR_GREATER
[Fact]
public void MaxBy_Arguments()
{
Expand All @@ -33,5 +34,6 @@ public void MaxBy_Empty()
{
AssertThrows<InvalidOperationException>(() => Enumerable.Empty<int>().MaxBy(x => x));
}
#endif
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ namespace Tests
{
public class Min : Tests
{
#if !NET6_0_OR_GREATER
[Fact]
public void Min_Arguments()
{
Expand All @@ -31,5 +32,6 @@ public int Compare(int x, int y)
return Comparer<int>.Default.Compare(x % 3, y % 3);
}
}
#endif
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ namespace Tests
{
public class MinBy : Tests
{
#if !NET6_0_OR_GREATER
[Fact]
public void MinBy_Arguments()
{
Expand All @@ -33,5 +34,6 @@ public void MinBy_Empty()
{
AssertThrows<InvalidOperationException>(() => Enumerable.Empty<int>().MinBy(x => x));
}
#endif
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

namespace Tests
{
#if !NETCOREAPP2_1
#if !NETCOREAPP2_1_OR_GREATER
public class SkipLast : Tests
{
[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

namespace Tests
{
#if !NETCOREAPP2_1
#if !NETCOREAPP2_1_OR_GREATER
public class TakeLast : Tests
{
[Fact]
Expand Down
2 changes: 1 addition & 1 deletion Ix.NET/Source/System.Interactive/System.Interactive.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

<ItemGroup>
<EmbeddedResource Include="Properties\System.Interactive.rd.xml" />
<ReferenceAssemblyProjectReference Include="..\refs\System.Interactive.Ref\System.Interactive.Ref.csproj" />
<ReferenceAssemblyProjectReference Include="..\refs\System.Interactive.Ref\System.Interactive.Ref.csproj" ReferenceOutputAssembly="false" />
</ItemGroup>

</Project>
3 changes: 3 additions & 0 deletions Ix.NET/Source/System.Interactive/System/Linq/Operators/Max.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ namespace System.Linq
{
public static partial class EnumerableEx
{

#if !(REFERENCE_ASSEMBLY && (NET6_0))
/// <summary>
/// Returns the maximum value in the enumerable sequence by using the specified comparer to compare values.
/// </summary>
Expand All @@ -24,5 +26,6 @@ public static TSource Max<TSource>(this IEnumerable<TSource> source, IComparer<T

return MaxBy(source, x => x, comparer).First();
}
#endif
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ namespace System.Linq
{
public static partial class EnumerableEx
{
#if !(REFERENCE_ASSEMBLY && (NET6_0))
/// <summary>
/// Returns the elements with the maximum key value by using the default comparer to compare key values.
/// </summary>
Expand Down Expand Up @@ -80,5 +81,6 @@ private static IList<TSource> ExtremaBy<TSource, TKey>(IEnumerable<TSource> sour

return result;
}
#endif
}
}
2 changes: 2 additions & 0 deletions Ix.NET/Source/System.Interactive/System/Linq/Operators/Min.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ namespace System.Linq
{
public static partial class EnumerableEx
{
#if !(REFERENCE_ASSEMBLY && (NET6_0))
/// <summary>
/// Returns the minimum value in the enumerable sequence by using the specified comparer to compare values.
/// </summary>
Expand All @@ -24,5 +25,6 @@ public static TSource Min<TSource>(this IEnumerable<TSource> source, IComparer<T

return MinBy(source, x => x, comparer).First();
}
#endif
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ namespace System.Linq
{
public static partial class EnumerableEx
{

#if !(REFERENCE_ASSEMBLY && (NET6_0))
/// <summary>
/// Returns the elements with the minimum key value by using the default comparer to compare key values.
/// </summary>
Expand Down Expand Up @@ -46,5 +48,6 @@ public static IList<TSource> MinBy<TSource, TKey>(this IEnumerable<TSource> sour

return ExtremaBy(source, keySelector, (key, minValue) => -comparer.Compare(key, minValue));
}
#endif
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace System.Linq
{
public static partial class EnumerableEx
{
#if !(REFERENCE_ASSEMBLY && (NETCOREAPP2_0 || NETSTANDARD2_1))
#if !(REFERENCE_ASSEMBLY && (NETCOREAPP2_1 || NETSTANDARD2_1))
/// <summary>
/// Bypasses a specified number of contiguous elements from the end of the sequence and returns the remaining elements.
/// </summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace System.Linq
{
public static partial class EnumerableEx
{
#if !(REFERENCE_ASSEMBLY && (NETCOREAPP2_0 || NETSTANDARD2_1))
#if !(REFERENCE_ASSEMBLY && (NETCOREAPP2_1 || NETSTANDARD2_1 ))
/// <summary>
/// Returns a specified number of contiguous elements from the end of the sequence.
/// </summary>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netcoreapp2.1;net461;netcoreapp3.1</TargetFrameworks>
<TargetFrameworks>netcoreapp2.1;net461;netcoreapp3.1;net6.0</TargetFrameworks>
<NoWarn>$(NoWarn);CS0618</NoWarn>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netcoreapp2.1;net461;netcoreapp3.1</TargetFrameworks>
<TargetFrameworks>netcoreapp2.1;net461;netcoreapp3.1;net6.0</TargetFrameworks>
<NoWarn>$(NoWarn);CS0618;CS8603;CS8625</NoWarn>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
<PropertyGroup>
<Description>Interactive Extensions Providers Library used to build query providers and express queries over enumerable sequences.</Description>
<AssemblyTitle>Interactive Extensions - Providers Library</AssemblyTitle>
<TargetFrameworks>netstandard1.0;netcoreapp2.0;netstandard2.1</TargetFrameworks>
<TargetFrameworks>netstandard1.0;netcoreapp2.1;netstandard2.1</TargetFrameworks>
<PackageTags>Ix;Interactive;Extensions;Enumerable</PackageTags>
<AssemblyName>System.Interactive.Providers</AssemblyName>
</PropertyGroup>

<PropertyGroup Condition="'$(TargetFramework)' == 'netstandard1.0'">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
<PropertyGroup>
<Description>Interactive Extensions Main Library used to express queries over enumerable sequences.</Description>
<AssemblyTitle>Interactive Extensions - Main Library</AssemblyTitle>
<AssemblyName>System.Interactive</AssemblyName>
<Authors>Microsoft</Authors>
<TargetFrameworks>netstandard1.0;netcoreapp2.0;netstandard2.1</TargetFrameworks>
<TargetFrameworks>netstandard1.0;netcoreapp2.1;netstandard2.1;net6.0</TargetFrameworks>
<PackageTags>Ix;Interactive;Extensions;Enumerable</PackageTags>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<Authors>Microsoft</Authors>
<TargetFrameworks>net461;netstandard2.0;netstandard2.1;netcoreapp3.1</TargetFrameworks>
<PackageTags>Enumerable;Asynchronous;LINQ</PackageTags>
<AssemblyName>System.Linq.Async</AssemblyName>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion Ix.NET/Source/version.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "5.1.0-preview.{height}",
"version": "5.1.0",
"publicReleaseRefSpec": [
"^refs/heads/main$", // we release out of main
"^refs/heads/rel/v\\d+\\.\\d+", // we also release branches starting with vN.N
Expand Down
11 changes: 8 additions & 3 deletions azure-pipelines.ix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,15 @@ stages:
vmImage: ubuntu-latest
steps:
- task: UseDotNet@2
displayName: Use .NET Core 5.0.x SDK
displayName: Use .NET Core 6.x SDK
inputs:
version: 5.0.x
includePreviewVersions: true
version: 6.x

- task: UseDotNet@2
displayName: .NET Core 5.0 runtime
inputs:
version: '5.0.x'
packageType: runtime

- task: UseDotNet@2
displayName: .NET Core 3.1 runtime
Expand Down