Skip to content

update property page enum values to match msbuild xsd #7740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2021
Merged

update property page enum values to match msbuild xsd #7740

merged 2 commits into from
Nov 4, 2021

Conversation

@jmarolf
Copy link
Contributor

@jmarolf jmarolf commented Nov 3, 2021 •
edited by ghost
Loading

see related PR here: dotnet/msbuild#6996

cc: @mavasani

Microsoft Reviewers: Open in CodeFlow

@jmarolf jmarolf requested a review from a team as a code owner November 3, 2021 22:22
drewnoakes
drewnoakes approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@drewnoakes drewnoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very similar to @mavasani's PR #7727 in which we discussed adding two combo boxes, which might be less confusing. Your team owns this page, so it's ultimately up to you to decide what is best. If you do wish to have two combo boxes, we can provide pointers on how to implement that.

@drewnoakes
Copy link
Member

drewnoakes commented Nov 3, 2021

The translations need to be updated to get the build passing.

@drewnoakes drewnoakes merged commit 30486e4 into dotnet:main Nov 4, 2021
@ghost ghost added this to the 17.1 milestone Nov 4, 2021
@drewnoakes drewnoakes mentioned this pull request Nov 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drewnoakes drewnoakes drewnoakes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

17.1

Development

Successfully merging this pull request may close these issues.

2 participants

@jmarolf @drewnoakes