Revert "Load Microsoft.DotNet.MSBuildSdkResolver into default load context (MSBuild.exe only) (#9439)" #9573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likely a red herring - closing (a separate issue will be opened for an unrelated issue hit with that change)
This reverts commit 6257b8e.
Context
Latest VS main msbuild fails to restore VS sources.
Testing
For a quicker test loop I was testing only on a specific project:
With the latest VS main (17.9.0 Preview 3.0 [34422.22.main]) it received bunch ofNU1604andNU1103- showing that dependencies versions were not properly resolved.When injected msbuild build on latest vs17.9 - the same symptomps remained.
When injected backsynced msbuild or msbuild from latest vs17.9 with reverted #9439 - the issues disappeared
With previous VS main (17.9.0 Preview 3.0 [34414.216.main]) - the issue doesn't reproWith previous VS main with injected msbuild build on latest vs17.9 - the same symptomps remained.
With the latest VS main (17.9.0 Preview 3.0 [34422.22.main]) it received bunch of
NU1604andNU1103- showing that dependencies versions were not properly resolved.When injected msbuild build on latest vs17.9 - the same symptomps remained.
When injected backsynced msbuild or msbuild from latest vs17.9 with reverted #9439 - the issues is still there (so likely that change is not a culprit)
When injected backsynced msbuild prior the inserted commits (to fcff9b0) - the issues is still there (so likely no msbuild change is a culprit)
With previous VS main (17.9.0 Preview 3.0 [34414.216.main]) - the issue doesn't repro
With previous VS main with injected msbuild build on latest vs17.9 - there is a different issue:
That issue dissapears when the #9439 is reverted. - that originaly misslead me to think it's a culprit. But it seems completely unrelated
Analysis
TBD - (separate item will be created)