Skip to content

Conversation

@JanKrivanek
Copy link
Member

@JanKrivanek JanKrivanek commented Dec 22, 2023

Likely a red herring - closing (a separate issue will be opened for an unrelated issue hit with that change)

This reverts commit 6257b8e.

Context

Testing

For a quicker test loop I was testing only on a specific project:

.\MSBuild.exe /t:Restore C:\src\VS\src\vset\Agile\TestPlatform\RocksteadyCLI\Rocksteady.csproj

With the latest VS main (17.9.0 Preview 3.0 [34422.22.main]) it received bunch of NU1604 and NU1103 - showing that dependencies versions were not properly resolved.
When injected msbuild build on latest vs17.9 - the same symptomps remained.
When injected backsynced msbuild or msbuild from latest vs17.9 with reverted #9439 - the issues disappeared

With previous VS main (17.9.0 Preview 3.0 [34414.216.main]) - the issue doesn't repro
With previous VS main with injected msbuild build on latest vs17.9 - the same symptomps remained.

With the latest VS main (17.9.0 Preview 3.0 [34422.22.main]) it received bunch of NU1604 and NU1103 - showing that dependencies versions were not properly resolved.
When injected msbuild build on latest vs17.9 - the same symptomps remained.
When injected backsynced msbuild or msbuild from latest vs17.9 with reverted #9439 - the issues is still there (so likely that change is not a culprit)
When injected backsynced msbuild prior the inserted commits (to fcff9b0) - the issues is still there (so likely no msbuild change is a culprit)

With previous VS main (17.9.0 Preview 3.0 [34414.216.main]) - the issue doesn't repro
With previous VS main with injected msbuild build on latest vs17.9 - there is a different issue:

C:\src\VS\Directory.Build.props(201,3): error : Could not resolve SDK "Microsoft.DevDiv.DownloadTasks". Exactly one of the probing messages below indicates why we could not resolve the SDK. Investigate and resolve that message to correctly specify the SDK.
C:\src\VS\Directory.Build.props(201,3): error :   The NuGetSdkResolver did not resolve this SDK because there was no version specified in the project or global.json.
C:\src\VS\Directory.Build.props(201,3): error :   MSB4276: The default SDK resolver failed to resolve SDK "Microsoft.DevDiv.DownloadTasks" because directory "C:\Program Files\Microsoft Visual Studio\2022\main-2\MSBuild\Sdks\Microsoft.DevDiv.DownloadTasks\Sdk" did not exist.
C:\src\VS\Directory.Build.props(201,31): error MSB4236: The SDK 'Microsoft.DevDiv.DownloadTasks' specified could not be found. [C:\src\VS\src\vset\Agile\TestPlatform\RocksteadyCLI\Rocksteady.csproj]

That issue dissapears when the #9439 is reverted. - that originaly misslead me to think it's a culprit. But it seems completely unrelated

Analysis

TBD - (separate item will be created)

@ghost
Copy link

ghost commented Dec 22, 2023

Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant