-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Delete checks for retired change waves #9480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should consider making a debug-only check in this property function to warn if there's an instance of a stale check like this.
I had the same thought after creating the PR. Technically the assert is validating user input which is generally discouraged but since the feature is used pretty much only internally I think it makes sense to add it. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically the assert is validating user input which is generally discouraged but since the feature is used pretty much only internally I think it makes sense to add it.
I agree--and I think making it debug-only is a good mitigation in case someone else is using it.
Context
We still have checks for a change wave that's already out of rotation.
Changes Made
[MSBuild]::AreFeaturesEnabled('17.0')is now unconditionally true, let's remove the checks fromMicrosoft.Common.CurrentVersion.targets.