Skip to content

Conversation

@rainersigwald
Copy link
Member

Summary

These strings were introduced in #9217 but caused loc breaks.

Fixes #9283.

Customer Impact

Bad translations in non-English locales.

Regression?

No, new strings with bad contents.

Testing

N/A (build + XLF stuff passes)

Risk

None AFAIK--only risk is not getting new translations which we already aren't.

These strings were introduced in dotnet#9217 but caused loc breaks.

Fixes dotnet#9283.
@ghost
Copy link

ghost commented Sep 27, 2023

Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version.

Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock, but we should probably add a test to the repo that validates these strings don't break whatever contract is expected of us.

@rainersigwald
Copy link
Member Author

we should probably add a test to the repo that validates these strings don't break whatever contract is expected of us.

I agree in principle but I think what caused the problem here was a comment? @cristianosuzuki77 do you know if there's something we can put in place here to prevent this sort of problem in the future?

@rainersigwald rainersigwald merged commit e2f0ea5 into dotnet:vs17.8 Sep 27, 2023
@rainersigwald rainersigwald deleted the late-17.8-loc branch September 27, 2023 21:45
@rainersigwald
Copy link
Member Author

Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version.

BTW I ignored this on purpose, and am managing flow of the resultant build so that it doesn't go anywhere.

bulatgrzegorz pushed a commit to bulatgrzegorz/selective-condition-evaluator that referenced this pull request Oct 16, 2023
These strings were introduced in dotnet#9217 but caused loc breaks.

Fixes dotnet#9283.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants