-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fixes dotnet/msbuild#8958 TerminalLogger in .NET 8.0.100-preview.6 issues audible alerts on iTerm2 #9060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ible alerts on iTerm2
rainersigwald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having to split every validation test output in 3 is a bit unfortunate but this works for me.
. . . Hmm, actually, can we set the mock terminal in the tests to not emit this code consistently except for a specific test for this behavior? Up to you whether that seems worth it.
It depends on test intention actually. If the intention is to test real life e2e scenario, and Mac output is currently indeed different, it's better to keep them split as is. Unless we "unseal" From my experience, it's worth to keep truly e2e scenarios unmocked. For specific tests, for example |
|
Unless there is more feedback on open items, this PR is ready to be merged. |
fixes #8958
Context
TerminalLogger in .NET 8.0.100-preview.6 issues audible alerts on iTerm2
Iterm2 treats ;9 code differently from ConEmu: https://iterm2.com/documentation-escape-codes.html
Changes Made
Disabled progress reporting on Mac
Testing
Tested manually on Mac
Notes