-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Expose static methods from System.OperatingSystem #8935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JaynieBai
merged 20 commits into
dotnet:main
from
jrdodds:AvailableStaticMethodsSystemOperatingSystem
Jul 6, 2023
Merged
Changes from 8 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4fcf002
Expose OperatingSystem static methods
jrdodds f3e563e
Merge branch 'dotnet:main' into AvailableStaticMethodsSystemOperating…
jrdodds 250df8e
make class internal
jrdodds 5d00cb2
Update comment in src/Build/Resources/Constants.cs
jrdodds 210dca4
Update comment in src/Framework/OperatingSystem.cs
jrdodds 908aa4b
Update comment in src/Framework/OperatingSystem.cs
jrdodds 296094b
flip #if test
jrdodds cc180fc
changes per review request; add missing unit test for IsOSPlatformVer…
jrdodds e4efcd4
add test case
jrdodds 541c4ba
add IsOSPlatformVersionAtLeast* test methods
jrdodds b0b7786
consolidate tests
jrdodds 6accf37
remove IsOSXLike()
jrdodds 387ef70
unit tests
jrdodds 558e8a6
expose only selected methods of System.OperatingSystem
jrdodds 30dea8f
per review request expose all static methods of System.OperatingSystem
jrdodds 16baa32
Merge branch 'dotnet:main' into AvailableStaticMethodsSystemOperating…
jrdodds f8dbc4a
Merge branch 'dotnet:main' into AvailableStaticMethodsSystemOperating…
jrdodds 6dde4c3
Merge branch 'dotnet:main' into AvailableStaticMethodsSystemOperating…
jrdodds 759ae6a
add comment to re-run build after unit test timeout
jrdodds ffeb0c3
Revert "add comment to re-run build after unit test timeout"
jrdodds File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using Shouldly; | ||
|
|
||
| using Xunit; | ||
| using Xunit.NetCore.Extensions; | ||
|
|
||
| namespace Microsoft.Build.Framework.UnitTests | ||
| { | ||
| public class OperatingSystem_Tests | ||
| { | ||
| #if !NET5_0_OR_GREATER | ||
| [WindowsFullFrameworkOnlyTheory] | ||
| [InlineData("windows", true)] | ||
| [InlineData("linux", false)] | ||
| [InlineData("macOS", false)] | ||
| public void IsOSPlatform(string platform, bool expected) | ||
| { | ||
| Microsoft.Build.Framework.OperatingSystem.IsOSPlatform(platform).ShouldBe(expected); | ||
| } | ||
|
|
||
| [WindowsFullFrameworkOnlyTheory] | ||
| [InlineData("windows", 4, true)] | ||
| [InlineData("windows", 999, false)] | ||
| [InlineData("linux", 0, false)] | ||
| [InlineData("macOS", 0, false)] | ||
| public void IsOSPlatformVersionAtLeast(string platform, int major, bool expected) | ||
| { | ||
| Microsoft.Build.Framework.OperatingSystem.IsOSPlatformVersionAtLeast(platform, major).ShouldBe(expected); | ||
| } | ||
|
|
||
| [WindowsFullFrameworkOnlyFact] | ||
| public void IsWindows() | ||
| { | ||
| Microsoft.Build.Framework.OperatingSystem.IsWindows().ShouldBeTrue(); | ||
| } | ||
|
|
||
| [WindowsFullFrameworkOnlyFact] | ||
| public void IsWindowsVersionAtLeast() | ||
| { | ||
| Microsoft.Build.Framework.OperatingSystem.IsWindowsVersionAtLeast(4).ShouldBeTrue(); | ||
| } | ||
|
|
||
| [WindowsFullFrameworkOnlyFact] | ||
| public void IsOtherThanWindows() | ||
| { | ||
| Microsoft.Build.Framework.OperatingSystem.IsFreeBSD().ShouldBeFalse(); | ||
| Microsoft.Build.Framework.OperatingSystem.IsFreeBSDVersionAtLeast(0).ShouldBeFalse(); | ||
| Microsoft.Build.Framework.OperatingSystem.IsLinux().ShouldBeFalse(); | ||
| Microsoft.Build.Framework.OperatingSystem.IsMacOS().ShouldBeFalse(); | ||
| Microsoft.Build.Framework.OperatingSystem.IsMacOSVersionAtLeast(0).ShouldBeFalse(); | ||
| Microsoft.Build.Framework.OperatingSystem.IsOSXLike().ShouldBeFalse(); | ||
| } | ||
| #endif | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| #if !NET5_0_OR_GREATER | ||
|
|
||
| using System; | ||
|
|
||
| namespace Microsoft.Build.Framework | ||
| { | ||
| /// <summary> | ||
| /// System.OperatingSystem static methods were added in net5.0. | ||
| /// This class creates stand-in methods for net472 builds. | ||
| /// Assumes only Windows is supported. | ||
| /// </summary> | ||
| internal static class OperatingSystem | ||
| { | ||
| public static bool IsOSPlatform(string platform) | ||
| { | ||
| return platform?.Equals("WINDOWS", StringComparison.OrdinalIgnoreCase) ?? throw new ArgumentNullException(nameof(platform)); | ||
| } | ||
|
|
||
| public static bool IsOSPlatformVersionAtLeast(string platform, int major, int minor = 0, int build = 0, int revision = 0) | ||
| => IsOSPlatform(platform) && IsOSVersionAtLeast(major, minor, build, revision); | ||
|
|
||
| public static bool IsLinux() => false; | ||
|
|
||
| public static bool IsFreeBSD() => false; | ||
|
|
||
| public static bool IsFreeBSDVersionAtLeast(int major, int minor = 0, int build = 0, int revision = 0) => false; | ||
|
|
||
| public static bool IsMacOS() => false; | ||
|
|
||
| public static bool IsOSXLike() => false; | ||
|
|
||
| public static bool IsMacOSVersionAtLeast(int major, int minor = 0, int build = 0) => false; | ||
|
|
||
| public static bool IsWindows() => true; | ||
|
|
||
| public static bool IsWindowsVersionAtLeast(int major, int minor = 0, int build = 0, int revision = 0) | ||
| => IsWindows() && IsOSVersionAtLeast(major, minor, build, revision); | ||
|
|
||
| private static bool IsOSVersionAtLeast(int major, int minor, int build, int revision) | ||
| { | ||
| Version current = Environment.OSVersion.Version; | ||
|
|
||
| if (current.Major != major) | ||
| { | ||
| return current.Major > major; | ||
| } | ||
|
|
||
| if (current.Minor != minor) | ||
| { | ||
| return current.Minor > minor; | ||
| } | ||
|
|
||
| if (current.Build != build) | ||
| { | ||
| return current.Build > build; | ||
| } | ||
|
|
||
| return current.Revision >= revision; | ||
| } | ||
| } | ||
| } | ||
| #endif | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.