[vs17.6] Dont ngen taskhost Fixes our lack of optprof data (#8737) #8926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't ngen TaskHosts
|
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
rainersigwald
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Note that this won't fix the builds by itself; we'll have to produce a build with disabled (or the old known-good) optprof data, spin up optprof collection, then rebuild with just a bumped version number.
Or we could just use the old known-good optprof data for 17.6.
ladipro
approved these changes
Jun 20, 2023
Forgind
approved these changes
Jun 20, 2023
Merged
This was referenced Jul 28, 2025
Closed
Closed
This was referenced Aug 4, 2025
Closed
Closed
This was referenced Aug 15, 2025
This was referenced Aug 29, 2025
This was referenced Oct 15, 2025
Closed
Open
This was referenced Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
OptProf failing on vs17.6 after recent changes
Fix
Cherrypicked #8737