Skip to content

Conversation

@oleksandr-didyk
Copy link
Contributor

Context

Contributes to dotnet/source-build#3435

Adds comments to source-build files asking for the inclusion of the source-build team in PRs that alter SourceBuild* files. Non-reviewed changes could potentially cause issues down the line, be it in the downstream repos or the product build (as has happened in the past, see dotnet/source-build#3435 (comment))

Changes Made

  • added comments to source-build files asking for the inclusion of the source-build team in PRs that alter SourceBuild* file.

Testing

Notes

Copy link
Member

@ladipro ladipro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious if we shouldn't add the CODEOWNERS file to enforce such rules.

@oleksandr-didyk
Copy link
Contributor Author

Curious if we shouldn't add the CODEOWNERS file to enforce such rules.

From past experience CODEOWNERS is a useful tool, but if you are tagging a team alias it will need to have write access to the repo for the entry to work.

Speaking of write access - I don't have it for msbuild so I cannot merge this PR myself. Would be great if someone from the maintainers could merge it. Thanks!

@JaynieBai JaynieBai merged commit 53a9293 into dotnet:main Jun 6, 2023
@oleksandr-didyk oleksandr-didyk deleted the add-sb-review-comment branch June 6, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants