Skip to content

Remove redundant copy of BuildRequestData.TargetNames #7252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Remove redundant copy of BuildRequestData.TargetNames #7252

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24d5afb
Remove redundant copy of BuildRequestData.TargetNames
dfederm Jan 11, 2022
f2d772c
Use a list
dfederm Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/Build/BackEnd/BuildManager/BuildRequestData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,6 @@ public BuildRequestData(string projectFullPath, IDictionary<string, string> glob
ErrorUtilities.VerifyThrowArgumentNull(globalProperties, nameof(globalProperties));

ProjectFullPath = FileUtilities.NormalizePath(projectFullPath);
TargetNames = (ICollection<string>)targetsToBuild.Clone();
GlobalPropertiesDictionary = new PropertyDictionary<ProjectPropertyInstance>(globalProperties.Count);
foreach (KeyValuePair<string, string> propertyPair in globalProperties)
{
Expand All @@ -238,7 +237,11 @@ private BuildRequestData(string[] targetsToBuild, HostServices hostServices, Bui
ErrorUtilities.VerifyThrowArgumentNull(targetsToBuild, nameof(targetsToBuild));

HostServices = hostServices;
TargetNames = new List<string>(targetsToBuild);

var targetsToBuildCopy = new string[targetsToBuild.Length];
targetsToBuild.CopyTo(targetsToBuildCopy, 0);
TargetNames = targetsToBuildCopy;

Flags = flags;
}

Expand Down