Skip to content

SA1014 #7235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2022
Merged

SA1014 #7235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6481072
SA1014 Opening generic brackets should not be preceded by a space
elachlan Jan 8, 2022
fbbc152
enable warning on SA1014
elachlan Jan 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Common.globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,7 +738,7 @@ dotnet_diagnostic.SA1012.severity = suggestion
dotnet_diagnostic.SA1013.severity = suggestion

# Opening generic brackets should not be preceded by a space
dotnet_diagnostic.SA1014.severity = suggestion
dotnet_diagnostic.SA1014.severity = warning

# Closing generic bracket should not be followed by a space
dotnet_diagnostic.SA1015.severity = suggestion
Expand Down
2 changes: 1 addition & 1 deletion src/Build.UnitTests/Construction/SolutionProjectGenerator_Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2351,7 +2351,7 @@ public void BeforeTargetsFromImportCanHookDynamicTarget()
projectInstance.Targets["MyTarget"].BeforeTargets.ShouldBe("DynamicTraversalTarget");

MockLogger mockLogger = new MockLogger(output);
projectInstance.Build(targetsToBuild, new List <ILogger> { mockLogger })
projectInstance.Build(targetsToBuild, new List<ILogger> { mockLogger })
.ShouldBeFalse("The solution build should have failed due to a missing project");
mockLogger.AssertLogContains("Message from MyTarget");
}
Expand Down