Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ or grab a [prebuilt Azure VM image](http://blogs.msdn.com/b/visualstudioalm/arch
3. Open src/MSBuild.sln solution in Visual Studio 2015.

## How to Engage, Contribute and Provide Feedback
Before you contribute, please read through the contributing and developer guides to get an idea of what kinds of pull requsts we will or won't accept.
Before you contribute, please read through the contributing and developer guides to get an idea of what kinds of pull requests we will or won't accept.

* [Contributing Guide](https://github.com/Microsoft/msbuild/wiki/Contributing-Code)
* [Developer Guide](https://github.com/Microsoft/msbuild/wiki/Building-Testing-and-Debugging)
Expand Down
2 changes: 1 addition & 1 deletion src/Framework/ProjectStartedEventArgs.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
namespace Microsoft.Build.Framework
{
/// <summary>
/// Arguements for project started events
/// Arguments for project started events
/// </summary>
/// <remarks>
/// WARNING: marking a type [Serializable] without implementing
Expand Down
2 changes: 1 addition & 1 deletion src/Shared/INodePacketTranslator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
namespace Microsoft.Build.BackEnd
{
/// <summary>
/// This delegate is used for objects which do not have public paramaterless constructors and must be constructed using
/// This delegate is used for objects which do not have public parameterless constructors and must be constructed using
/// another method. When invoked, this delegate should return a new object which has been translated appropriately.
/// </summary>
/// <typeparam name="T">The type to be translated.</typeparam>
Expand Down
2 changes: 1 addition & 1 deletion src/Shared/UnitTests/MockLogger.cs
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ public void Shutdown()
/*
* Method: LoggerEventHandler
*
* Recieves build events and logs them the way we like.
* Receives build events and logs them the way we like.
*
*/
internal void LoggerEventHandler(object sender, BuildEventArgs eventArgs)
Expand Down
8 changes: 4 additions & 4 deletions src/Utilities/MuxLogger.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ namespace Microsoft.Build.Utilities
{
/// <summary>
/// This is a multiplexing logger. The purpose of this logger is to allow the registration and deregistration of
/// multiple loggers during the build. This is to support the VS IDE scenario where loggers are regisered and unregistered
/// multiple loggers during the build. This is to support the VS IDE scenario where loggers are registered and unregistered
/// for each project system's build request. This means one physical build may have multiple logical builds
/// each with their own set of loggers.
///
/// The Mux logger will register itself with the build manager as a regular central /l style logger.
/// It will be responsible for recieving messages from the build manager and route them to the correct
/// It will be responsible for receiving messages from the build manager and route them to the correct
/// logger based on the logical build the message came from.
///
/// Requirements:
Expand All @@ -34,7 +34,7 @@ namespace Microsoft.Build.Utilities
///
/// 3) The MUX logger will be shutdown when the build is finished in end build . At this time it will un-register any loggers attached to it.
///
/// 4) The MUX logger will log the build finsished event when the project finished event for the first project started event is seen for each logger.
/// 4) The MUX logger will log the build finished event when the project finished event for the first project started event is seen for each logger.
///
/// Registering Loggers:
///
Expand All @@ -46,7 +46,7 @@ namespace Microsoft.Build.Utilities
/// UnRegisterLogger:
/// When a build submission is completed the UnregisterLogger method will be called with the submission ID.
/// At this point we will look up the success state of the project finished event for the submission ID and log a build finished event to the logger.
/// The event source will be cleaned up. This may be interesting because the unregister will come from a thread other than what is doign the logging.
/// The event source will be cleaned up. This may be interesting because the unregister will come from a thread other than what is doing the logging.
/// This may create a Synchronization issue, if unregister is called while events are being logged.
///
/// UNDONE: If we can use ErrorUtilities, replace all InvalidOperation and Argument exceptions with the appropriate calls.
Expand Down
2 changes: 1 addition & 1 deletion src/Utilities/UnitTests/MockLogger.cs
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ public void Shutdown()
/*
* Method: LoggerEventHandler
*
* Recieves build events and logs them the way we like.
* Receives build events and logs them the way we like.
*
*/
internal void LoggerEventHandler(object sender, BuildEventArgs eventArgs)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ internal enum BuildRequestEntryState
/// must be non-null.
///
/// Transitions:
/// Ready: All of the results which caused the build request to wait have been recieved
/// Ready: All of the results which caused the build request to wait have been received
/// </summary>
Waiting,

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ static internal IBuildComponent CreateComponent(BuildComponentType type)
}

/// <summary>
/// We have recieved the node shutdown packet for this node, we should remove it from our list of providers.
/// We have received the node shutdown packet for this node, we should remove it from our list of providers.
/// </summary>
private void RemoveNodeFromMapping(int nodeId)
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright (c) Microsoft. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.
// </copyright>
// <summary>Sink which will take in a build event and raiise it on its internal event source</summary>
// <summary>Sink which will take in a build event and raise it on its internal event source</summary>
//-----------------------------------------------------------------------

using System;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ bool RunningOnRemoteNode
/// <summary>
/// Allows the registering of an ICentralLogger and a forwarding logger pair
/// </summary>
/// <param name="centralLogger">Central logger which is to recieve the events created by the forwarding logger</param>
/// <param name="centralLogger">Central logger which is to receive the events created by the forwarding logger</param>
/// <param name="forwardingLogger">A description of the forwarding logger</param>
/// <returns value="bool">True if the central and forwarding loggers were registered. False if the central logger or the forwarding logger were already registered</returns>
bool RegisterDistributedLogger(ILogger centralLogger, LoggerDescription forwardingLogger);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -642,7 +642,7 @@ public void ShutdownComponent()
}

/// <summary>
/// Will recieve a logging packet and send it to the correct
/// Will receive a logging packet and send it to the correct
/// sink which is registered to the LoggingServices.
/// PacketReceived should be called from a single thread.
/// </summary>
Expand All @@ -669,7 +669,7 @@ public void PacketReceived(int node, INodePacket packet)

/// <summary>
/// Register an instantiated logger which implements the ILogger interface. This logger will be registered to a specific event
/// source (the central logger event source) which will recieve all logging messages for a given build.
/// source (the central logger event source) which will receive all logging messages for a given build.
/// This should not be used on a node, Loggers are not to be registered on a child node.
/// </summary>
/// <param name="logger">ILogger</param>
Expand Down Expand Up @@ -760,12 +760,12 @@ public void UnregisterAllLoggers()
///
/// The central logger is initialized before the distributed logger
/// </summary>
/// <param name="centralLogger">Central logger to recieve messages from the forwarding logger, This logger cannot have been registered before</param>
/// <param name="forwardingLogger">Logger description which describes how to create the forwarding logger, the logger description canot have been used before</param>
/// <param name="centralLogger">Central logger to receive messages from the forwarding logger, This logger cannot have been registered before</param>
/// <param name="forwardingLogger">Logger description which describes how to create the forwarding logger, the logger description cannot have been used before</param>
/// <returns value="bool">True if the distributed and central logger were registered, false if they either were already registered</returns>
/// <exception cref="InternalErrorException">If forwardingLogger is null</exception>
/// <exception cref="LoggerException">If a logger exception is thown while creating or initializing the distributed or central logger</exception>
/// <exception cref="InternalLoggerException">If any exception (other than a loggerException)is thown while creating or initializing the distributed or central logger, we will wrap these exceptions in an InternalLoggerException</exception>
/// <exception cref="LoggerException">If a logger exception is thrown while creating or initializing the distributed or central logger</exception>
/// <exception cref="InternalLoggerException">If any exception (other than a loggerException)is thrown while creating or initializing the distributed or central logger, we will wrap these exceptions in an InternalLoggerException</exception>
public bool RegisterDistributedLogger(ILogger centralLogger, LoggerDescription forwardingLogger)
{
lock (_lockObject)
Expand Down Expand Up @@ -1111,7 +1111,7 @@ private void LoggingEventProcessor(object loggingEvent)
bool cultureSet = false;
try
{
// If we have a componenthost then set the culture on the first message we recieve
// If we have a componenthost then set the culture on the first message we receive
if (_componentHost != null)
{
originalCultureInfo = Thread.CurrentThread.CurrentCulture;
Expand Down Expand Up @@ -1205,7 +1205,7 @@ private void RouteBuildEvent(BuildEventArgs eventArg)
_filterEventSource.Consume(eventArg);

// Now that the forwarding loggers have been given the chance to log the build started and finished events we need to check the
// central logger sinks to see if they have recieved the events or not. If the sink has not recieved the event we need to send it to the
// central logger sinks to see if they have received the events or not. If the sink has not received the event we need to send it to the
// logger for backwards compatibility with orcas.
// In addition we need to make sure we manually forward the events because in orcas the forwarding loggers were not allowed to
// forward build started or build finished events. In the new OM we allow the loggers to forward the events. However since orcas did not forward them
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public void LogError(BuildEventContext location, BuildEventFileInfo file, string
/// <param name="file">File information about where the error happened</param>
/// <param name="messageResourceName">String index into the string.resx file</param>
/// <param name="messageArgs">Arguments for the format string in the resource file</param>
/// <exception cref="InternalErrorException">MessageResouceName is null</exception>
/// <exception cref="InternalErrorException">MessageResourceName is null</exception>
public void LogError(BuildEventContext buildEventContext, string subcategoryResourceName, BuildEventFileInfo file, string messageResourceName, params object[] messageArgs)
{
lock (_lockObject)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ internal interface IRequestBuilderCallback

/// <summary>
/// Instructs the RequestBuilder that next Build request from a task should post its request
/// and immeditely return so that the thread may be freed up. May not be nested.
/// and immediately return so that the thread may be freed up. May not be nested.
/// </summary>
void EnterMSBuildCallbackState();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
namespace Microsoft.Build.BackEnd
{
/// <summary>
/// Interface implemted by the Target Builder which allows tasks to invoke targets and build projects.
/// Interface implemented by the Target Builder which allows tasks to invoke targets and build projects.
/// </summary>
internal interface ITargetBuilderCallback : IRequestBuilderCallback
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ public IEnumerable<ScheduleResponse> ReportResult(int nodeId, BuildResult result
ScheduleResponse response = TrySatisfyRequestFromCache(request.Parent.AssignedNode, request.BuildRequest, skippedResultsAreOK: false);

// response may be null if the result was never added to the cache. This can happen if the result has an exception in it
// or the results could not be satisfied becasue the initial or default targets have been skipped. If that is the case
// or the results could not be satisfied because the initial or default targets have been skipped. If that is the case
// we need to report the result directly since it contains an exception
if (response == null)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace Microsoft.Build.Construction
public sealed class SolutionConfigurationInSolution
{
/// <summary>
/// Default seperator between configuration and platform in configuration
/// Default separator between configuration and platform in configuration
/// full names
/// </summary>
internal const char ConfigurationPlatformSeparator = '|';
Expand Down
2 changes: 1 addition & 1 deletion src/XMakeBuildEngine/Definition/ProjectCollection.cs
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ public ProjectCollection(IDictionary<string, string> globalProperties, IEnumerab
}

/// <summary>
/// Handler to recieve which project got added to the project collection.
/// Handler to receive which project got added to the project collection.
/// </summary>
[SuppressMessage("Microsoft.Design", "CA1034:NestedTypesShouldNotBeVisible", Justification = "This has been API reviewed")]
public delegate void ProjectAddedEventHandler(object sender, ProjectAddedToProjectCollectionEventArgs e);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ internal override bool BoolEvaluate(ConditionEvaluator.IConditionEvaluationState

// Ignore invalid characters or path related exceptions

// We will ignore the PathTooLong exception caused by GetFullPath becasue in single proc this code
// We will ignore the PathTooLong exception caused by GetFullPath because in single proc this code
// is not executed and the condition is just evaluated to false as File.Exists and Directory.Exists does not throw in this situation.
// To be consistant with that we will return a false in this case also.
// DevDiv Bugs: 46035
Expand Down
4 changes: 2 additions & 2 deletions src/XMakeBuildEngine/Logging/NullCentralLogger.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
namespace Microsoft.Build.BackEnd.Logging
{
/// <summary>
/// This class will throw an exception when it recieves any event except for the build started or build finished event
/// This class will throw an exception when it receives any event except for the build started or build finished event
/// this logger is good to use if a distributed logger is attached but does not want to forward any events
/// </summary>
internal class NullCentralLogger : INodeLogger
Expand Down Expand Up @@ -56,7 +56,7 @@ public void AnyEventRaisedHandler(object sender, BuildEventArgs e)
{
if (!(e is BuildStartedEventArgs) && !(e is BuildFinishedEventArgs))
{
ErrorUtilities.VerifyThrowInvalidOperation(false, "Should not recieve any events other than build started or finished");
ErrorUtilities.VerifyThrowInvalidOperation(false, "Should not receive any events other than build started or finished");
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/XMakeBuildEngine/UnitTests/BackEnd/BuildManager_Tests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ public void RunOutOfProcBuild(Action<BuildParameters> buildParametersModifier)
}

/// <summary>
/// Make sure when we are doign an inprocess build that even if the environment variable msbuildforwardpropertiesfromchild is set that we still
/// Make sure when we are doing an inprocess build that even if the environment variable msbuildforwardpropertiesfromchild is set that we still
/// get all of the initial properties.
/// </summary>
[TestMethod]
Expand Down Expand Up @@ -389,7 +389,7 @@ public void InProcForwardPropertiesFromChild()
}

/// <summary>
/// Make sure when we are doign an inprocess build that even if the environment variable MsBuildForwardAllPropertiesFromChild is set that we still
/// Make sure when we are doing an inprocess build that even if the environment variable MsBuildForwardAllPropertiesFromChild is set that we still
/// get all of the initial properties.
/// </summary>
[TestMethod]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public void TestConstructorValidInputs()
}

/// <summary>
/// Verify when an event is forwarded, the event that was put in is the same event that was recieved on the event source
/// Verify when an event is forwarded, the event that was put in is the same event that was received on the event source
/// also make sure the sinkId has been updated by the event redirector.
/// </summary>
[TestMethod]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ public bool EnteredStatusEventHandler
/// <summary>
/// Which event was raised on the event source, this can be asserted upon
/// to verify the event passed to the event source is the same one which was
/// recieved by the event handlers
/// received by the event handlers
/// </summary>
public BuildEventArgs RaisedEvent
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ public void LogWarningTests()

#region LogWarningErrorFromText
/// <summary>
/// Verify an InternalErrorException is thown when a null BuildEventContext is passed in
/// Verify an InternalErrorException is thrown when a null BuildEventContext is passed in
/// </summary>
[TestMethod]
[ExpectedException(typeof(InternalErrorException))]
Expand Down
2 changes: 1 addition & 1 deletion src/XMakeBuildEngine/UnitTests/BackEnd/TaskHost_Tests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1083,7 +1083,7 @@ public void Shutdown()
}

/// <summary>
/// Log if we have recieved any event.
/// Log if we have received any event.
/// </summary>
internal void EventSource_AnyEventRaised(object sender, BuildEventArgs e)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
namespace Microsoft.Build.UnitTests.QA
{
/// <summary>
/// An interfacing representing a build request defination cache.
/// An interfacing representing a build request definition cache.
/// </summary>
internal interface ITestDataProvider
{
Expand Down
2 changes: 1 addition & 1 deletion src/XMakeBuildEngine/UnitTests/QaTests/MockResultsCache.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ namespace Microsoft.Build.UnitTests.QA
/// <summary>
/// Mock Implementation of the results cache which does captures some counters and provides it
/// back to the tests for validation purposes. Most of the implementation is routed to the default component
/// by means of aggrigration
/// by means of aggregation
/// </summary>
internal class QAResultsCache : IResultsCache, IBuildComponent
{
Expand Down
2 changes: 1 addition & 1 deletion src/XMakeTasks/AssemblyDependency/NoMatchReason.cs
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ internal enum NoMatchReason
NotAFileNameOnDisk,

/// <summary>
/// The processor architecure does not match the targeted processor architecture.
/// The processor architecture does not match the targeted processor architecture.
/// </summary>
ProcessorArchitectureDoesNotMatch
}
Expand Down
Loading