Skip to content

Spurious Windows test failure in FindOnPathSucceeds #6975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2021
Merged

Spurious Windows test failure in FindOnPathSucceeds #6975

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01eda9c
Convert path to lowercase to repair flaky unit test fact FindOnPathSu…
Adityanr Oct 20, 2021
a35df79
toLower() to toUpperInvariant() fix
Adityanr Oct 20, 2021
f76629f
pass linux and macos unit tests
Adityanr Oct 20, 2021
9e2f629
code refactored
Adityanr Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Utilities.UnitTests/ToolTask_Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,16 +683,16 @@ public void FindOnPathSucceeds()
string shellName;
if (NativeMethodsShared.IsWindows)
{
expectedCmdPath = new[] { Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.System), "cmd.exe") };
expectedCmdPath = new[] { Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.System), "cmd.exe").ToUpperInvariant() };
shellName = "cmd.exe";
}
else
{
expectedCmdPath = new[] { "/bin/sh", "/usr/bin/sh" };
expectedCmdPath = new[] { "/bin/sh".ToUpperInvariant(), "/usr/bin/sh".ToUpperInvariant() };
shellName = "sh";
}

string cmdPath = ToolTask.FindOnPath(shellName);
string cmdPath = ToolTask.FindOnPath(shellName).ToUpperInvariant();

cmdPath.ShouldBeOneOf(expectedCmdPath);
}
Expand Down