Skip to content

Add missing match on metadata location translation #6972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2021
Merged

Add missing match on metadata location translation #6972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Build.UnitTests/TestComparers/ProjectInstanceModelTestComparers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,12 @@ public bool Equals(ProjectItemGroupTaskItemInstance x, ProjectItemGroupTaskItemI
Assert.Equal(x.RemoveMetadataLocation, y.RemoveMetadataLocation, new Helpers.ElementLocationComparerIgnoringType());
Assert.Equal(x.ConditionLocation, y.ConditionLocation, new Helpers.ElementLocationComparerIgnoringType());

Assert.Equal(x.MatchOnMetadata, y.MatchOnMetadata);
Assert.Equal(x.MatchOnMetadataLocation, y.MatchOnMetadataLocation, new Helpers.ElementLocationComparerIgnoringType());

Assert.Equal(x.MatchOnMetadataOptions, y.MatchOnMetadataOptions);
Assert.Equal(x.MatchOnMetadataOptionsLocation, y.MatchOnMetadataOptionsLocation, new Helpers.ElementLocationComparerIgnoringType());

Assert.Equal(x.Metadata, y.Metadata, new TargetItemMetadataComparer());

return true;
Expand Down
2 changes: 2 additions & 0 deletions src/Build/Instance/ProjectItemGroupTaskItemInstance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,8 @@ void ITranslatable.Translate(ITranslator translator)
translator.Translate(ref _keepMetadataLocation, ElementLocation.FactoryForDeserialization);
translator.Translate(ref _removeMetadataLocation, ElementLocation.FactoryForDeserialization);
translator.Translate(ref _keepDuplicatesLocation, ElementLocation.FactoryForDeserialization);
translator.Translate(ref _matchOnMetadataLocation, ElementLocation.FactoryForDeserialization);
translator.Translate(ref _matchOnMetadataOptionsLocation, ElementLocation.FactoryForDeserialization);
translator.Translate(ref _conditionLocation, ElementLocation.FactoryForDeserialization);
translator.Translate(ref _metadata, ProjectItemGroupTaskMetadataInstance.FactoryForDeserialization);
}
Expand Down